Skip to content

curl{,Minimal}: patchShebang of wcurl script with host Bash#493004

Open
doronbehar wants to merge 1 commit intoNixOS:stagingfrom
doronbehar:pkg/curl@cross.tmp
Open

curl{,Minimal}: patchShebang of wcurl script with host Bash#493004
doronbehar wants to merge 1 commit intoNixOS:stagingfrom
doronbehar:pkg/curl@cross.tmp

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Feb 22, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@doronbehar
curl{,Minimal}: patchShebang of wcurl script with host Bash
8244c80 
wcurl's shebang is patched to use build platform runtimeShell in
`postPatch`, and it is easier to `--update` its shebangs instead of
filtering it out in `postPatch`.
@doronbehar doronbehar mentioned this pull request Feb 22, 2026
Open
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Feb 22, 2026
@nixpkgs-ci nixpkgs-ci bot requested review from Scrumplex and lovek323 February 22, 2026 11:46
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 22, 2026
Scrumplex
Scrumplex approved these changes Feb 22, 2026
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Optional: Perhaps we can reduce rebuilds and merge to master by only adding this for cross builds (i.e. lib.optionalString (stdenv.hostPlatform != stdenv.buildPlatform))

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 22, 2026
@artemist
Copy link
Member

artemist commented Feb 23, 2026

Unfortunately optionalString wouldn't work here, postFixup = "" is different than no postFixup. You could make it conditional by putting it in env with an optionalAttrs or by setting it to null when when it is not needed.

I don't see either that much in the nixpkgs codebase, I might be missing something.

@doronbehar
Copy link
Contributor Author

doronbehar commented Feb 25, 2026

This is not urgent for me, so I'd prefer to go straight to the correct solution, even if it has to go through staging. I'm not merging this yet based upon @Scrumplex's approval because I am still hopeful that @emilazy will reply to my comment in the PR that attempts to generalize this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronbehar @artemist @Scrumplex