lirc: split outputs, and patch several FHS issues#493000
lirc: split outputs, and patch several FHS issues#493000doronbehar wants to merge 6 commits intoNixOS:masterfrom
Conversation
SuperSandro2000
left a comment
There was a problem hiding this comment.
not sure about the patch shebangs but if you think it is correct, fine for me
|
Thanks for the approval, I mainly asked for your review regarding the split outputs. As for the |
It is complex enough for a patch, and it is too complex for a `substituteInPlace` command. A sed command can become a no-op and is much harder to maintain.
|
It was a bit hard, but I managed to split the |
| rm $out/bin/lirc-setup | ||
| ln -s $out/${python3.sitePackages}/lirc-setup/lirc-setup $out/bin/lirc-setup |
There was a problem hiding this comment.
| rm $out/bin/lirc-setup | |
| ln -s $out/${python3.sitePackages}/lirc-setup/lirc-setup $out/bin/lirc-setup | |
| ln -fs $out/${python3.sitePackages}/lirc-setup/lirc-setup $out/bin/lirc-setup |
There was a problem hiding this comment.
Thanks for the suggestion @SuperSandro2000 , but I was sort of thinking about doing that, and I decided that an explicit rm (and not rm -f) is better because this way it'll be easy to detect that the file is not present - in case in the future upstream will stop distributing it. What do you think?
Things done
pulseaudioFullrhythmboxnixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.