Skip to content

lirc: split outputs, and patch several FHS issues#493000

Open
doronbehar wants to merge 6 commits intoNixOS:masterfrom
doronbehar:pkg/lirc
Open

lirc: split outputs, and patch several FHS issues#493000
doronbehar wants to merge 6 commits intoNixOS:masterfrom
doronbehar:pkg/lirc

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Feb 22, 2026

Things done

@nixpkgs-ci nixpkgs-ci bot requested a review from pSub February 22, 2026 11:37
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Feb 22, 2026
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the patch shebangs but if you think it is correct, fine for me

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 22, 2026
@doronbehar
Copy link
Contributor Author

Thanks for the approval, I mainly asked for your review regarding the split outputs. $out contains many references to $out/bin, which makes splitting a bin output hard. I tried today a bit harder to split it never the less, and I gave up. I did however found out a few other small fixes that are still substantial which I'd like to get your review upon.

As for the patchShebangs topic - I'll leave that to another PR.

@doronbehar doronbehar changed the title lirc: use host shebangs in installed scripts lirc: split outputs, and patch several FHS issues Feb 23, 2026
@doronbehar
Copy link
Contributor Author

It was a bit hard, but I managed to split the $lib output - which will make most of the packages in Nixpkgs that depend on lirc only reference lirc.lib - greatly reducing the closure size of it.

@doronbehar doronbehar removed the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Feb 23, 2026
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Feb 23, 2026
Comment on lines +132 to +133
rm $out/bin/lirc-setup
ln -s $out/${python3.sitePackages}/lirc-setup/lirc-setup $out/bin/lirc-setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rm $out/bin/lirc-setup
ln -s $out/${python3.sitePackages}/lirc-setup/lirc-setup $out/bin/lirc-setup
ln -fs $out/${python3.sitePackages}/lirc-setup/lirc-setup $out/bin/lirc-setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @SuperSandro2000 , but I was sort of thinking about doing that, and I decided that an explicit rm (and not rm -f) is better because this way it'll be easy to detect that the file is not present - in case in the future upstream will stop distributing it. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly ping @SuperSandro2000 🏓 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants