Skip to content

tests.*: extend the existing config#492152

Merged
jopejoe1 merged 4 commits intoNixOS:masterfrom
emilazy:push-tlzyzytxplxy
Feb 20, 2026
Merged

tests.*: extend the existing config#492152
jopejoe1 merged 4 commits intoNixOS:masterfrom
emilazy:push-tlzyzytxplxy

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Feb 19, 2026

There can be load‐bearing things in config (e.g. forbidden licences, EULA agreements, and – in my case – a flag to silence a warning that would otherwise break CI). We should probably find a better solution for this kind of thing in general other than re‐importing Nixpkgs, but this fixes the immediate issue.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@emilazy emilazy requested a review from jopejoe1 February 19, 2026 16:10
@nixpkgs-ci nixpkgs-ci bot requested a review from philiptaron February 19, 2026 16:16
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) labels Feb 19, 2026
Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement to what we had before, in the long term, we should think of a different way than this. There is also some other stuff that gets lost when reimporting.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 19, 2026
@jopejoe1 jopejoe1 added this pull request to the merge queue Feb 20, 2026
Merged via the queue into NixOS:master with commit 01f3f2e Feb 20, 2026
35 of 37 checks passed
@emilazy emilazy deleted the push-tlzyzytxplxy branch March 2, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants