tests.*: extend the existing config#492152
Merged
jopejoe1 merged 4 commits intoNixOS:masterfrom Feb 20, 2026
Merged
Conversation
13 tasks
jopejoe1
approved these changes
Feb 19, 2026
Member
jopejoe1
left a comment
There was a problem hiding this comment.
An improvement to what we had before, in the long term, we should think of a different way than this. There is also some other stuff that gets lost when reimporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can be load‐bearing things in
config(e.g. forbidden licences, EULA agreements, and – in my case – a flag to silence a warning that would otherwise break CI). We should probably find a better solution for this kind of thing in general other than re‐importing Nixpkgs, but this fixes the immediate issue.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.