nixos/starship: skip one program invocation on each shell init#490728
Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom Feb 16, 2026
Merged
nixos/starship: skip one program invocation on each shell init#490728SigmaSquadron merged 1 commit intoNixOS:masterfrom
SigmaSquadron merged 1 commit intoNixOS:masterfrom
Conversation
The code that is being evaled without the `--print-full-init` flag is this: ``` eval -- "$(/nix/store/...-starship-1.24.2/bin/starship init bash --print-full-init)" ``` We can skip one program invocation and directly call `starship init bash --print-full-init`. This is a replication of my other PR in home-manager: - nix-community/home-manager#2862
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
bot
removed
the
9.needs: reviewer
SigmaSquadron
approved these changes
Feb 16, 2026
Contributor
SigmaSquadron
left a comment
SigmaSquadron
left a comment
There was a problem hiding this comment.
Seems good to me. Tests still pass.
Contributor
|
Might also be nice to get nix-community/home-manager#8705 into Nixpkgs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that is being evaled without the
--print-full-initflag is this:We can skip one program invocation and directly call
starship init bash --print-full-init.This is a replication of my other PR in home-manager:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.