Skip to content

pngcheck: use shared zlib#490616

Merged
doronbehar merged 2 commits intoNixOS:masterfrom
doronbehar:pkg/pngcheck@zlib
Feb 17, 2026
Merged

pngcheck: use shared zlib#490616
doronbehar merged 2 commits intoNixOS:masterfrom
doronbehar:pkg/pngcheck@zlib

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented Feb 15, 2026 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from starcraft66 February 15, 2026 09:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Feb 15, 2026
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 15, 2026
@doronbehar doronbehar mentioned this pull request Feb 15, 2026
Merged
1 task
@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Feb 17, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 490616
Commit: 66d19139eb38e7cea40482cb5dcc061ed37a4c28

aarch64-linux

✅ 1 package built:
  • pngcheck

x86_64-darwin

✅ 1 package built:
  • pngcheck

aarch64-darwin

✅ 1 package built:
  • pngcheck

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Feb 17, 2026

This is working for me with several png files... Any comments @starcraft66 ?

@doronbehar doronbehar added this pull request to the merge queue Feb 17, 2026
Merged via the queue into NixOS:master with commit a04d172 Feb 17, 2026
40 of 42 checks passed
@doronbehar doronbehar deleted the pkg/pngcheck@zlib branch February 17, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcin-serwin marcin-serwin marcin-serwin approved these changes

+1 more reviewer

@starcraft66 starcraft66 starcraft66 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronbehar @starcraft66 @marcin-serwin