Skip to content

hap-py: remove#490615

Closed
doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar:pkg/hap-py
Closed

hap-py: remove#490615
doronbehar wants to merge 1 commit intoNixOS:masterfrom
doronbehar:pkg/hap-py

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from apraga February 15, 2026 09:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 15, 2026
Copy link
Copy Markdown
Contributor

@marcin-serwin marcin-serwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait for the nixpkgs maintainer

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 15, 2026
@apraga
Copy link
Copy Markdown
Contributor

apraga commented Feb 15, 2026 via email

@doronbehar
Copy link
Copy Markdown
Contributor Author

Friendly ping @apraga .

@apraga
Copy link
Copy Markdown
Contributor

apraga commented Mar 5, 2026

@doronbehar I'm on it, I fixed a cmake issue but there are compilation errors not present before.

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Mar 6, 2026 via email

apraga added a commit to apraga/nixpkgs that referenced this pull request Mar 6, 2026
Avoid removal by NixOS#490615. Changes
- fix missing header
- add missing library
- comile with latest Boost
apraga added a commit to apraga/nixpkgs that referenced this pull request Mar 6, 2026
Avoid removal by NixOS#490615. Changes
- fix missing header
- add missing library
- comile with latest Boost
@apraga
Copy link
Copy Markdown
Contributor

apraga commented Mar 6, 2026

It builds again ! #497380 is the PR, let me know if there are formatting issues (I haven't contributed for some time).

@apraga apraga mentioned this pull request Mar 6, 2026
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 8, 2026
stepbrobd pushed a commit to stepbrobd/nixpkgs that referenced this pull request Mar 9, 2026
Avoid removal by NixOS#490615. Changes
- fix missing header
- add missing library
- comile with latest Boost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants