Skip to content

bintools-wrapper: disable libcxxhardeningextensive hardening flag by default#490358

Open
risicle wants to merge 1 commit intoNixOS:stagingfrom
risicle:ris-libcxxhardeningextensive-default-disable
Open

bintools-wrapper: disable libcxxhardeningextensive hardening flag by default#490358
risicle wants to merge 1 commit intoNixOS:stagingfrom
risicle:ris-libcxxhardeningextensive-default-disable

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Feb 14, 2026

Enabling it by default in #442945 was not intentional and likely the result of a bad final rebase before merge. This flag likely has a negative effect on performance for some packages.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@risicle risicle force-pushed the ris-libcxxhardeningextensive-default-disable branch from c1445d6 to d8d07a0 Compare February 14, 2026 11:40
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azahi azahi Awaiting requested review from azahi

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@reckenrode reckenrode Awaiting requested review from reckenrode

@RossSmyth RossSmyth Awaiting requested review from RossSmyth

Assignees

No one assigned

Labels

8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@risicle