Skip to content

katawa-shoujo-re-engineered: compile rpy files in the build phase #490290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UlyssesZh wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −4
Open

katawa-shoujo-re-engineered: compile rpy files in the build phase #490290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions pkgs/by-name/ka/katawa-shoujo-re-engineered/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,34 @@ stdenvNoCC.mkDerivation (finalAttrs: {
nativeBuildInputs = [
makeWrapper
copyDesktopItems
renpy
];

dontBuild = true;
configurePhase = ''
runHook preConfigure

substituteInPlace game/config.rpy --replace-fail 0.0.0-localbuild ${finalAttrs.version}

runHook postConfigure
'';
Comment on lines +40 to +46
Copy link
Contributor

@quantenzitrone quantenzitrone Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if separate, that definitely belongs in the patchPhase

Suggested change
configurePhase = ''
runHook preConfigure
substituteInPlace game/config.rpy --replace-fail 0.0.0-localbuild ${finalAttrs.version}
runHook postConfigure
'';
postPatch = ''
substituteInPlace game/config.rpy --replace-fail 0.0.0-localbuild ${finalAttrs.version}
'';

Copy link
Member Author

@UlyssesZh UlyssesZh Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this definitely is the configure phase.

Copy link
Contributor

@quantenzitrone quantenzitrone Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm i don't know enough about what the configure phase is supposed to be other than autotools specific running the ./configure script.
so since you're so sure, i'll let it go


buildPhase = ''
runHook preBuild

renpy . compile

runHook postBuild
'';

installPhase = ''
runHook preInstall

mkdir -p $out/bin
makeWrapper ${lib.getExe' renpy "renpy"} $out/bin/${finalAttrs.meta.mainProgram} \
--add-flags ${finalAttrs.src} --add-flags run
phome=$out/share/kataswa-shoujo-re-engineered
mkdir -p $phome
cp -r game $phome
find $phome -type f -name "*.rpy" -delete
makeWrapper ${lib.getExe renpy} $out/bin/${finalAttrs.meta.mainProgram} \
--add-flags $phome --add-flags run
install -D $src/web-icon.png $out/share/icons/hicolor/512x512/apps/${finalAttrs.meta.mainProgram}.png

runHook postInstall
Expand All @@ -64,6 +82,7 @@ stdenvNoCC.mkDerivation (finalAttrs: {
maintainers = with lib.maintainers; [
quantenzitrone
rapiteanu
ulysseszhan
];
platforms = renpy.meta.platforms;
};
Expand Down
Loading