Skip to content

sonic-server: fix build with GCC 15#490266

Merged
mdaniels5757 merged 1 commit intoNixOS:masterfrom
anthonyroussel:fix-sonic-build
Feb 14, 2026
Merged

sonic-server: fix build with GCC 15#490266
mdaniels5757 merged 1 commit intoNixOS:masterfrom
anthonyroussel:fix-sonic-build

Conversation

@anthonyroussel
Copy link
Member

@anthonyroussel anthonyroussel commented Feb 14, 2026

See #475479, valeriansaliou/sonic#337

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@anthonyroussel
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 490266
Commit: 333b1fb6302894e4ad59be4961f3e9467562072b (subsequent changes)
Merge: 8910561dee730bfc83297e1dade83988fb17996d

Logs: https://github.com/anthonyroussel/nixpkgs-review-gha/actions/runs/22007455676


x86_64-linux

✅ 1 package built:
  • sonic-server

aarch64-linux

✅ 1 package built:
  • sonic-server

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • sonic-server

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • sonic-server

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Feb 14, 2026
@anthonyroussel
Copy link
Member Author

anthonyroussel commented Feb 14, 2026

Bot check is failing:

[4](https://github.com/NixOS/nixpkgs/actions/runs/22016954786/job/63620192647?pr=490266#step:6:45)
Error: Labeling #490266 failed.
Notice: Processed 1 PRs, 0 Issues, made 18 API requests and downloaded 1 artifacts.
    at handle (/home/runner/work/nixpkgs/nixpkgs/ci/github-script/bot.js:666:13)
    at async /home/runner/work/nixpkgs/nixpkgs/ci/github-script/bot.js:679:7
    at async module.exports (/home/runner/work/nixpkgs/nixpkgs/ci/github-script/withRateLimit.js:56:5)
    at async module.exports (/home/runner/work/nixpkgs/nixpkgs/ci/github-script/bot.js:677:3) {
  [cause]: RequestError [HttpError]: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the NixOS/nixpkgs repository.
      at /home/runner/work/_actions/actions/github-script/ed597411d8f924073f98dfc5c65a23a2325f34cd/dist/index.js:9537:21
      at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
      at async requestWithGraphqlErrorHandling (/home/runner/work/_actions/actions/github-script/ed597411d8f924073f98dfc5c65a23a2325f34cd/dist/index.js:9276:20)
      at async Job.doExecute (/home/runner/work/_actions/actions/github-script/ed597411d8f924073f98dfc5c65a23a2325f34cd/dist/index.js:10275:18) {
    status: 422,
    response: {
      url: 'https://api.github.com/repos/NixOS/nixpkgs/pulls/490266/requested_reviewers',
      status: 422,
      headers: [Object],
      data: [Object]
    },
    request: {
      method: 'POST',
      url: 'https://api.github.com/repos/NixOS/nixpkgs/pulls/490266/requested_reviewers',
      headers: [Object],
      body: '{"reviewers":["pleshevskiy"],"team_reviewers":[]}',
      request: [Object]
    }
  }
}

@pleshevskiy cannot be added as reviewer of this PR.

Looks like this issue already happened here: #370456 (comment)

Maybe this user enabled Code review limits for NixOS or enabled temporary interaction limits.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Feb 14, 2026
@mdaniels5757
Copy link
Member

I split your second commit into #490497: we'll have to wait a week for that, but don't need to wait for this one.

@mdaniels5757 mdaniels5757 added this pull request to the merge queue Feb 14, 2026
Merged via the queue into NixOS:master with commit 65a53f8 Feb 14, 2026
51 of 56 checks passed
@anthonyroussel anthonyroussel deleted the fix-sonic-build branch February 14, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants