sonic-server: fix build with GCC 15#490266
Merged
mdaniels5757 merged 1 commit intoNixOS:masterfrom Feb 14, 2026
Merged
Conversation
Member
Author
|
333b1fb to
c5c0df2
Compare
Member
Author
|
Bot check is failing: [4](https://github.com/NixOS/nixpkgs/actions/runs/22016954786/job/63620192647?pr=490266#step:6:45)
Error: Labeling #490266 failed.
Notice: Processed 1 PRs, 0 Issues, made 18 API requests and downloaded 1 artifacts.
at handle (/home/runner/work/nixpkgs/nixpkgs/ci/github-script/bot.js:666:13)
at async /home/runner/work/nixpkgs/nixpkgs/ci/github-script/bot.js:679:7
at async module.exports (/home/runner/work/nixpkgs/nixpkgs/ci/github-script/withRateLimit.js:56:5)
at async module.exports (/home/runner/work/nixpkgs/nixpkgs/ci/github-script/bot.js:677:3) {
[cause]: RequestError [HttpError]: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the NixOS/nixpkgs repository.
at /home/runner/work/_actions/actions/github-script/ed597411d8f924073f98dfc5c65a23a2325f34cd/dist/index.js:9537:21
at process.processTicksAndRejections (node:internal/process/task_queues:103:5)
at async requestWithGraphqlErrorHandling (/home/runner/work/_actions/actions/github-script/ed597411d8f924073f98dfc5c65a23a2325f34cd/dist/index.js:9276:20)
at async Job.doExecute (/home/runner/work/_actions/actions/github-script/ed597411d8f924073f98dfc5c65a23a2325f34cd/dist/index.js:10275:18) {
status: 422,
response: {
url: 'https://api.github.com/repos/NixOS/nixpkgs/pulls/490266/requested_reviewers',
status: 422,
headers: [Object],
data: [Object]
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/NixOS/nixpkgs/pulls/490266/requested_reviewers',
headers: [Object],
body: '{"reviewers":["pleshevskiy"],"team_reviewers":[]}',
request: [Object]
}
}
}@pleshevskiy cannot be added as reviewer of this PR. Looks like this issue already happened here: #370456 (comment) Maybe this user enabled Code review limits for NixOS or enabled temporary interaction limits. |
42f9365 to
c5c0df2
Compare
Member
|
I split your second commit into #490497: we'll have to wait a week for that, but don't need to wait for this one. |
mdaniels5757
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #475479, valeriansaliou/sonic#337
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.