update-users-groups.pl: Use UTF-8 instead of latin1.#4896
Closed
ruediger wants to merge 1 commit intoNixOS:masterfrom
Closed
update-users-groups.pl: Use UTF-8 instead of latin1.#4896ruediger wants to merge 1 commit intoNixOS:masterfrom
ruediger wants to merge 1 commit intoNixOS:masterfrom
Conversation
Perl seems to write the file in latin1 independent of the actual input encoding. This can corrupt the "description" field of /etc/passwd. By setting "binmode" to ":utf8" Perl can be forced to write UTF-8. Ideally the program would simply read/write the fields by value without any changes in encoding. However, assuming/enforcing UTF-8 is a lot better than using an obsolete coding like latin1.
aristidb
added
0.kind: enhancement
Contributor
|
Merged manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perl seems to write the file in latin1 independent of the actual input
encoding. This can corrupt the
descriptionfield of/etc/passwd. Bysetting
binmodeto:utf8Perl can be forced to write UTF-8. Ideallythe program would simply read/write the fields by value without any
changes in encoding. However, assuming/enforcing UTF-8 is a lot better
than using an obsolete coding like latin1.