Skip to content

circus: use python313Packages, move to by-name#488849

Merged
kirillrdy merged 2 commits intoNixOS:masterfrom
GaetanLepage:circus
Feb 9, 2026
Merged

circus: use python313Packages, move to by-name#488849
kirillrdy merged 2 commits intoNixOS:masterfrom
GaetanLepage:circus

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Feb 9, 2026 •
edited
Loading

Things done

  • circus: use python3Packages instead of python310Packages
  • circus: move to by-name

Tracking: #488818

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 9, 2026
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 9, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 488849
Commit: 2c3e961b7b257aa3e5731e584430b5d729601de9

@kirillrdy kirillrdy added this pull request to the merge queue Feb 9, 2026
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 9, 2026
Merged via the queue into NixOS:master with commit 0e7970c Feb 9, 2026
31 checks passed
@GaetanLepage GaetanLepage deleted the circus branch February 9, 2026 21:18
@mweinelt mweinelt mentioned this pull request Feb 9, 2026
Closed
7 tasks
@qweered
Copy link
Contributor

qweered commented Feb 9, 2026

So are we okay with #454559 (comment)

@kirillrdy
Copy link
Member

kirillrdy commented Feb 11, 2026

are you referring to breaking override api ?
it's a known issue, i guess it's less of an issue for some packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirillrdy kirillrdy kirillrdy approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaetanLepage @qweered @kirillrdy