navidrome: 0.60.0 -> 0.60.3

[tebriel]

changelog: https://github.com/navidrome/navidrome/releases/tag/v0.60.3
changelog: https://github.com/navidrome/navidrome/releases/tag/v0.60.2

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[DieracDelta]

srcbot: Full Evaluation Results for PR #488091

compared base commit 6ea241d9 against head of PR commit 451a7d74

Command

target/release/srcbot verify \
  --full-eval \
  --prs 488091 \
  --aggressively-check-fods true \
  --nixpkgs /home/jrestivo/dev/nixpkgs \
  --remote-builder jrestivo@100.104.74.94 \
  --remote-system aarch64-linux \
  --remote-build-jobs 2 \
  --build-jobs 2 \
  --eval-workers 1 \
  --false-positive \
  --verify-full-drvs \
  --save-location /srv/srcbot \
  --log-base-url https://nixos-arm.tail5ca7.ts.net/srcbot-srv/ \
  --remote-gc-threshold 180G \
  --remote-gc-keep-days 1

Status: 4/4 packages passed, 0 failed across 2 architectures
Tests: 3/4 passed, 1 failed

x86_64-linux

2 packages passed (all with tests)

Package	Steps Built	Tests
navidrome	src, goModules, npmDeps, package	navidrome
nixpkgs-manual	package	manpage-urls

aarch64-linux

Test Failures - 1 packages with failing tests

Package	Failed Tests
navidrome	navidrome

2 packages passed (all with tests)

Package	Steps Built	Tests
navidrome	src, goModules, npmDeps, package	-
nixpkgs-manual	package	manpage-urls

[DieracDelta]

The failing test is (again) a false positive because the runner doesn't have kvm.

[Lord-Valen]

0.60.3 was released.

[cimm]

I tried to install Navidrome version 0.60.3 from this pull request using an overlay, but got the following error:

github.com/navidrome/navidrome/adapters/taglib: invalid flag in pkg-config --cflags: --define-prefix
error: Cannot build '/nix/store/kslqk9dbr1r4x9jz0fnxsar1k4z38gj9-navidrome-0.60.3.drv'.
       Reason: builder failed with exit code 1.
       Output paths:
         /nix/store/wwxpnhik2fscc787bf02j8nmarqcvk8x-navidrome-0.60.3
error: Cannot build '/nix/store/hgnh8sgwc219f90g8gp01f15fr43qik6-unit-navidrome.service.drv'.
       Reason: 1 dependency failed.
       Output paths:
         /nix/store/97cil03bbhm41k6q09xsiakpazkyhabr-unit-navidrome.service
error: Cannot build '/nix/store/mz4hvbvyngl1wx8cdasv1g0prizhg9lz-system-units.drv'.
       Reason: 1 dependency failed.
       Output paths:
         /nix/store/fjb7r2c9c4inl08ywd75ii8hwgwrdhc8-system-units
error: Cannot build '/nix/store/6cvqw5jrwy2izhgdgij5jdm68bnbz39j-etc.drv'.
       Reason: 1 dependency failed.
       Output paths:
         /nix/store/rlfb6iqfixgjdal7dq8kwhjwc3wgkhhz-etc
error: Cannot build '/nix/store/a6s6xk2ba78nqcwcmgrfl7sbbcw5df7p-nixos-system-example-25.11.5960.3aadb7ca9eac.drv'.
       Reason: 1 dependency failed.
       Output paths:
         /nix/store/8sivr8gaf9a4nmnfa77s00msihzkk80y-nixos-system-example-25.11.5960.3aadb7ca9eac
Command 'nix-build '<nixpkgs/nixos>' --attr config.system.build.toplevel --no-out-link' returned non-zero exit status 100.

This is the same error as I get with version 0.59.0, the version from nixpgs stable. The error is detailed in #481611 and seems related to the version of golang.

In other words, it doesn't create a new error, but neither does it fix the existing one.

[tebriel]

@cimm isn't the default version of golang in 25.11 different from the default in unstable? If so the fact that this uses buildGoModule which uses the default version of golang is your problem, as part of your overlay you'll also have to override the version of golang.

[DieracDelta]

+1

I just wanted to add: I've been daily driving 0.60.2 and now 0.60.3 (as an overlay that's the same hashes as this PR). It's not 100% the same (I'm running a few of the new wasm plugins) and I'm not on stable. But just as some empirical data--I think this should reproducibly work on master.

[cimm]

@tebriel You're absolutely right! I forgot I wasn't running unstable. I gave it another shot on unstable, and it works as expected. Sorry about the confusion!

[coyotoid]

will this get backported to stable once merged? stable is still on 0.59.0 which fails to build, or is it not possible due to the golang version used by default in stable?

[tebriel]

@coyotoid I think we'd only backport it if there were security issues.

stable is still on 0.59.0 which fails to build

Are you saying that 0.59.0 is broken in stable or that's just the last version that works in stable?

You could use a combination of disabledModules and import to pull in just the module and package from unstable if you want the updated version. Example

[coyotoid]

@tebriel I see, wrt backports.

Are you saying that 0.59.0 is broken in stable or that's just the last version that works in stable?

It's broken in stable.

[not-my-profile]

#481611 is the issue about the build failure on stable. Yeah I think this should be backported to fix that failure.

[tebriel]

I'm not sure backporting this change will fix stable 👀

[tebriel]

@not-my-profile @coyotoid try out #493362 for release-25.11 build issues.

[andresilva]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 488091
Commit: 9f116f63c044032c3f9b72563eb5dee8a1098f44

---

x86_64-linux

❌ 1 package failed to build:

• navidrome

---

Error logs: `x86_64-linux`

navidrome

- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 6.67s
PWA v1.2.0

Building src/sw.js service worker ("es" format)...

vite v7.3.1 building client environment for production...

✓ 1 modules transformed.

build/sw.mjs  0.87 kB │ gzip: 0.46 kB │ map: 2.59 kB

✓ built in 7ms
PWA v1.2.0

mode      injectManifest

format:   es

precache  14 entries (2530.14 KiB)

files generated

build/sw.js

build/sw.js.map

Building subPackage .

github.com/navidrome/navidrome/adapters/taglib: invalid flag in pkg-config --cflags: --define-prefix

[andresilva]

#493362 fixes the build above (also needed on unstable now).

[tebriel]

@andresilva rebased on upstream, validated the error, added the patch and validated the fix.

[andresilva]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 488091
Commit: 7deb465c9b80880cd32f72b8b39716a573e02d28

---

x86_64-linux

✅ 1 package built:

• navidrome

[andresilva]

LGTM will merge once you update that comment. We can then backport this and replace #493362.

[nixpkgs-ci]

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-488091-to-release-25.11 origin/release-25.11
cd .worktree/backport-488091-to-release-25.11
git switch --create backport-488091-to-release-25.11
git cherry-pick -x 1a13ff7aaa65cee4271854cfb41f01f006b20864

[andresilva]

Backport will need the module changes as well.