Skip to content

todoman: disable failing test#487589

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
antonmosich:todoman-disable
Feb 6, 2026
Merged

todoman: disable failing test#487589
dotlambda merged 1 commit intoNixOS:masterfrom
antonmosich:todoman-disable

Conversation

@antonmosich
Copy link
Contributor

The update to urwid 3.0.4 breaks this test but I could not find any breakage when testing the build result. Furthermore the test runs again with urwid 3.0.5 This needs an updated wcwidth, which was updated in 3002493 which is currently in staging.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

The update to urwid 3.0.4 breaks this test but I could not find any
breakage when testing the build result. Furthermore the test runs again
with urwid 3.0.5, which needs to go via staging.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 6, 2026
@antonmosich antonmosich requested a review from dotlambda February 6, 2026 10:55
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 6, 2026
@dotlambda dotlambda enabled auto-merge February 6, 2026 22:05
@dotlambda dotlambda added this pull request to the merge queue Feb 6, 2026
@dotlambda
Copy link
Member

Furthermore the test runs again with urwid 3.0.5

I'll revert this PR in #487674.

Merged via the queue into NixOS:master with commit b9c921b Feb 6, 2026
35 of 37 checks passed
@antonmosich
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants