Revert "First-class GitHub team reviews"#487507
Merged
mdaniels5757 merged 1 commit intomasterfrom Feb 6, 2026
Merged
Conversation
This reverts commit 193deb8.
27db993 to
0d74c65
Compare
zowoq
approved these changes
Feb 6, 2026
Member
Author
|
Not sure this is the cause anymore? Why would https://github.com/NixOS/nixpkgs/actions/runs/21736909443/job/62704023950 succeed? |
Contributor
|
I'll close and reopen to retry CI in this PR. |
Contributor
|
Still failing here and #487506. |
Member
Author
|
Ah! https://github.com/NixOS/nixpkgs/actions/runs/21736909443/job/62704023950 has neither users nor teams to request, and the others do have users or teams to request. We should merge this, then. |
Member
Author
|
Bot workflow is back to normal again after reverting: https://github.com/NixOS/nixpkgs/actions/runs/21737295746/job/62704963889. |
Member
|
Sorry for the problem! Another try in #487955 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #456481
This seems to break the Bot workflow and step: https://github.com/NixOS/nixpkgs/actions/runs/21735690914/job/62700395870?pr=487491; https://github.com/NixOS/nixpkgs/actions/runs/21736338983/job/62702309324