Skip to content

pasystray: new package#4871

Merged
cillianderoiste merged 2 commits intoNixOS:masterfrom
exlevan:master
Nov 7, 2014
Merged

pasystray: new package#4871
cillianderoiste merged 2 commits intoNixOS:masterfrom
exlevan:master

Conversation

@exlevan
Copy link
Contributor

@exlevan exlevan commented Nov 7, 2014

No description provided.

@cillianderoiste
Copy link
Member

It looks good, but it's lacking the standard meta attributes: license, maintainers (please add yourself to lib/maintainers.nix), platforms and homepage. Thanks!

@exlevan
Copy link
Contributor Author

exlevan commented Nov 7, 2014

I've added meta attributes, except there is no homepage, only a github README file.

@cillianderoiste
Copy link
Member

Awesome thanks, I'd say the platforms should be linux rather than unix (I don't think OS X users will want/need a PulseAudio system tray), could you add the github project page as the homepage?

@exlevan
Copy link
Contributor Author

exlevan commented Nov 7, 2014

I think linux ++ openbsd ++ freebsd ++ netbsd would be better choice, since on all these platforms both pulseaudio and xorg are supported.
On unrelated note, in lib/platforms.nix, shouldn't netbsd be included in unix and all?

@cillianderoiste
Copy link
Member

Unfortunately, nix hasn't worked on the BSDs for a long time.

@exlevan
Copy link
Contributor Author

exlevan commented Nov 7, 2014

Ah, ok. Just linux, then.

cillianderoiste added a commit that referenced this pull request Nov 7, 2014
@cillianderoiste cillianderoiste merged commit 1fe98d4 into NixOS:master Nov 7, 2014
@cillianderoiste
Copy link
Member

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants