Conversation
|
Would you mind adding yourself as maintainer? |
|
Oh sure, would love to, just have no idea how to. I presumed the admin of the account gives me write access. |
|
@sjmackenzie we mean maintainer of a package in nixpkgs. Add yourself to |
17e9e2c to
bd74a06
Compare
bd74a06 to
02e4f82
Compare
|
@peti while you're at it, would you mind merging this one (unless there is anything else to be done) |
There was a problem hiding this comment.
IMO, it's better to rewrite as
stdenv.mkDerivation rec {
name = "ccnx-${version}";
version = "0.8.2";
(No let is needed)
There was a problem hiding this comment.
Which one is better: let or rec?
There was a problem hiding this comment.
Non-recursive attribute sets are preferable because they are cheaper to evaluate. I believe the actual difference is miniscule in practice, though, and both let and rec styles are used in Nixpkgs depending on the personal preference of the package's maintainer.
There was a problem hiding this comment.
Polluting the shell environment with $version might be another nit-picky reason, but I agree it's mostly a matter of personal taste.
rfc: AFAIU the only way to get this to build is to
mkdir -p $out/*. Is there a better way?