Skip to content

new package: ccnx#4868

Merged
peti merged 1 commit intoNixOS:masterfrom
sjmackenzie:new-pkg-ccnx
Nov 7, 2014
Merged

new package: ccnx#4868
peti merged 1 commit intoNixOS:masterfrom
sjmackenzie:new-pkg-ccnx

Conversation

@sjmackenzie
Copy link
Contributor

rfc: AFAIU the only way to get this to build is to mkdir -p $out/*. Is there a better way?

@pSub
Copy link
Member

pSub commented Nov 7, 2014

Would you mind adding yourself as maintainer?

@sjmackenzie
Copy link
Contributor Author

Oh sure, would love to, just have no idea how to. I presumed the admin of the account gives me write access.

@offlinehacker
Copy link
Contributor

@sjmackenzie we mean maintainer of a package in nixpkgs. Add yourself to lib/maintainers.nix and then add maintainer entry to meta data in package.

@sjmackenzie sjmackenzie force-pushed the new-pkg-ccnx branch 3 times, most recently from 17e9e2c to bd74a06 Compare November 7, 2014 16:55
@sjmackenzie
Copy link
Contributor Author

@peti while you're at it, would you mind merging this one (unless there is anything else to be done)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's better to rewrite as

stdenv.mkDerivation rec {
  name = "ccnx-${version}";
  version = "0.8.2";

(No let is needed)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one is better: let or rec?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-recursive attribute sets are preferable because they are cheaper to evaluate. I believe the actual difference is miniscule in practice, though, and both let and rec styles are used in Nixpkgs depending on the personal preference of the package's maintainer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polluting the shell environment with $version might be another nit-picky reason, but I agree it's mostly a matter of personal taste.

peti added a commit that referenced this pull request Nov 7, 2014
@peti peti merged commit 5be65c8 into NixOS:master Nov 7, 2014
@sjmackenzie sjmackenzie deleted the new-pkg-ccnx branch November 8, 2014 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants