Conversation
There was a problem hiding this comment.
Why did you drop the old replacement? We prefer that over LD_LIBRARY_PATH.
There was a problem hiding this comment.
@lethalman Do we?
└─› grep -r 'substituteInPlace.*\.c.*\.so' pkgs | wc -l
1
└─› grep -r 'wrapProgram.*LD_LIBRARY_PATH' pkgs | wc -l
26
Personally I believe, patching .c is ugly compared to wrapping with the correct LD_LIBRARY_PATH. Patching is acceptable if and only if there is no another cleaner way around.
There was a problem hiding this comment.
Patching seems to be safer. We've seen a ton of interesting ways wrappers break,
Now, substituteInPlace is not the only way to do it…
There was a problem hiding this comment.
Yes, please do not use LD_LIBRARY_PATH. Patch sources to point exactly to their runtime dependencies. If you never got a crash due to unresolved symbols when using nixos, it's because we do use precise runtime dependencies.
|
AFAIK this breaks xbmc. |
|
Testing a patch now. |
|
Pushed to master. |
4 participants
Also some minor changes that I believe to be enhancements.