crowdsec-blocklist-import: init at 1.1.0#486054
Conversation
|
| runtimeDeps = [ | ||
| curl | ||
| coreutils | ||
| gnugrep | ||
| gawk | ||
| ]; |
There was a problem hiding this comment.
Are those used somewhere? Do we want to use resholve instead?
There was a problem hiding this comment.
I tried resholve but as far as I can see, it needs to user rec instead of finalAttrs: and requires a solution attribute set which looks like a lot of boilerplate, compared to setting runtimeDeps. Is it worthwhile ? Any implmentation suggestions for solution ?
There was a problem hiding this comment.
Anyway for the moment this block isn't needed do to the module's path inclusion of /run/current-system/sw/bin/
There was a problem hiding this comment.
I used wrapProgram instead
5c3cfa8 to
defe768
Compare
|
This latest push addresses most of the comments, while keeping a working state. Failed attempts to address comments have been included as commented. |
|
Setting to draft for the time being. BTW what is the convention about who is expected to mark review comments as resolved ? |
|
Hey @gaelj — really cool to see this getting packaged for NixOS! Thanks for putting in the work on the systemd service/timer integration. A couple of things that might be useful:
Together they give you: threat feed import → CrowdSec detection → UniFi enforcement, all without touching the gateway filesystem. Happy to make any upstream changes to make packaging easier. Let me know if you need anything! |
fe7ce75 to
22ac588
Compare
22ac588 to
130d678
Compare
130d678 to
c94881c
Compare
|
Converted to draft for now, as I yet have to see an interaction with upstream being responded to by a human rather that a half-broken AI chatbot. The repo is MIT licensed and the idea is interesting, so I'm thinking I might be forking it and / or rewriting it in Python rather than Bash. |
c94881c to
230c3ea
Compare
|
Upstream maintainer here 👋 Great to see this being packaged for NixOS — the module looks well-structured with solid systemd hardening and CrowdSec integration. A few notes:
Happy to help get this over the finish line. Will update here once the upstream release is tagged. 🤖 This comment was generated by Claude AI assisting the maintainer. |
7b3233b to
03a21a8
Compare
51a5bb6 to
415bdb4
Compare
10a4cdd to
9ecd09b
Compare
9ecd09b to
cebdf64
Compare
cebdf64 to
3c930e7
Compare

Things done
Made a package and module for https://github.com/wolffcatskyy/crowdsec-blocklist-import
The module defines a systemd service and a systemd timer.
@wolffcatskyy @TornaxO7 @06kellyjac @SuperSandro2000
journalctl logs:
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.