unar: migrate package and top-level argument to by-name#486023
Closed
guylamar2006 wants to merge 1 commit intoNixOS:masterfrom
Closed
unar: migrate package and top-level argument to by-name#486023guylamar2006 wants to merge 1 commit intoNixOS:masterfrom
guylamar2006 wants to merge 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
qweered
approved these changes
Feb 1, 2026
nixpkgs-ci
bot
added
12.approvals: 1
drupol
reviewed
Feb 1, 2026
| @@ -12,7 +12,7 @@ | |||
| xcbuildHook, | |||
| }: | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
Contributor
There was a problem hiding this comment.
This PR title is misleading. This is more than a move to by-name. Why replacing stdenv with clangStdenv?
guylamar2006
changed the title
Contributor
|
Why closing the PR? |
Contributor
Author
Contributor
|
Next time, it would be nice to have a bit of empathy for reviewers, and by default mention the reason why you're closing the PR, I don't think this is the first time I ask you. Also, instead of linking to a commit, please link to a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate unar to by-name
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.