Skip to content

fetchPnpmDeps: Pass --no-run-if-empty to xargs to prevent running chmod without args#485258

Closed
Nymphium wants to merge 1 commit into
NixOS:masterfrom
Nymphium:fetchpnpmdeps-xargs
Closed

fetchPnpmDeps: Pass --no-run-if-empty to xargs to prevent running chmod without args#485258
Nymphium wants to merge 1 commit into
NixOS:masterfrom
Nymphium:fetchpnpmdeps-xargs

Conversation

@Nymphium

@Nymphium Nymphium commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

This PR updates fetchPnpmDeps to pass --no-run-if-empty to xargs. This prevents errors when find returns no results.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested review from Scrumplex and gepbird January 30, 2026 08:55
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels Jan 30, 2026

@gepbird gepbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you give an example package that is broken without this?

From the manpage:

This option is a GNU extension.

I'm not sure which coreutils/find package we ship to other platforms, testing it on darwin or bsd would be nice.

@gepbird gepbird marked this pull request as draft February 2, 2026 14:12
@gepbird

gepbird commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Superseded by #513736

@gepbird gepbird closed this Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants