check-meta: remove support for meta.tests #485131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this nerver worked as meta can not contain derivations and this required the tests to be derivations lets just not allow this. Also tests now days are set in passthru.tests, so even if it would work, we are already using a diffrent convention. This was introduced in NixOS#44439 Allowing derivations in meta issue NixOS/nix#2532
nixpkgs-ci
bot
requested review from
Artturin,
Ericson2314,
RossComputerGuy,
adisbladis,
emilazy,
philiptaron and
reckenrode
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
Jan 30, 2026
nixpkgs-ci
bot
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this nerver worked as meta can not contain derivations and this required the tests to be derivations
lets just not allow this.
Also tests now days are set in passthru.tests,
so even if it would work, we are already using a diffrent convention.
This was introduced in #44439 Allowing derivations in meta issue NixOS/nix#2532
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.