Merged
Conversation
yshui
force-pushed
the
clang-tools-wrapper
branch
from
b6d7e11 to
395298b
Compare
nixpkgs-ci
bot
requested review from
Ericson2314,
RossComputerGuy,
alyssais,
emilazy,
lovek323,
rrbutani and
sternenseemann
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
$CPATH is taken to mean the same thing as -I by clang, whereas $C_INCLUDE_PATH is -isystem. Using $CPATH means tools like clangd will generate warnings for problems in system headers, which is undesirable. See llvm/llvm-project#154015
yshui
force-pushed
the
clang-tools-wrapper
branch
from
395298b to
0273d9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #462747 (staging) and #475078 (master) added handling of
-cxx-isystemtobuildcpath, but that's not strictly correct. Since-cxx-isystemis meant for C++ headers. This could cause wrong headers to be included.The other problem is that, the current wrapper uses
$CPATH, which is actually the wrong environment variable to useThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.