Skip to content

various: remove unused argument overrides#483746

Merged
gepbird merged 1 commit intoNixOS:masterfrom
mdaniels5757:remove-unused-overrides
Jan 25, 2026
Merged

various: remove unused argument overrides#483746
gepbird merged 1 commit intoNixOS:masterfrom
mdaniels5757:remove-unused-overrides

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Jan 25, 2026

Overriding the argument with the same default value as in package.nix is pointless.

Split from #474456.

This is a step towards #454525, which will help enable checking for additional by-name directories (e.g. Python) in nixpkgs-vet.

Things done

Overriding the argument with the same default value as in package.nix is
pointless.

Co-authored-by: Michael Daniels <mdaniels5757@gmail.com>
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 25, 2026
@mdaniels5757 mdaniels5757 changed the title various: remove unused argument overrides various: remove unused argument overrides (part 4) Jan 25, 2026
@mdaniels5757 mdaniels5757 changed the title various: remove unused argument overrides (part 4) various: remove unused argument overrides Jan 25, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 25, 2026
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gepbird gepbird added this pull request to the merge queue Jan 25, 2026
Merged via the queue into NixOS:master with commit 6095dea Jan 25, 2026
53 of 54 checks passed
@mdaniels5757 mdaniels5757 deleted the remove-unused-overrides branch January 25, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants