haskellPackages.warp: stop including Paths_ module by default

[lf-]

This was made possible to disable, which we should really probably just do. It might make some HTTP servers not return their version in a header, but that feels like an antipattern anyhow.

See: yesodweb/wai#1044
See:

nixpkgs/pkgs/development/haskell-modules/configuration-darwin.nix

Lines 363 to 372 in ecdb2e3

	# Workarounds for justStaticExecutables on aarch64-darwin. Since dead code
	# elimination barely works on aarch64-darwin, any package that has a
	# dependency that uses a Paths_ module will incur a reference on GHC, making
	# it fail with disallowGhcReference (which is set by justStaticExecutables).
	#
	# To address this, you can either manually remove the references causing this
	# after verifying they are indeed erroneous (e.g. cabal2nix) or just disable
	# the check, sticking with the status quo. Ideally there'll be zero cases of
	# the latter in the future!
	cabal2nix = overrideCabal (old: {

I did try to use nix why-depends to verify that this is actually changing the things appearing in a .a file but didn't see anything in the diff. I am nonetheless submitting this patch because I did have this problem in practice at work; it's slightly hard to pin down the exact circumstances leading to it presenting itself.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[sternenseemann]

Since this is such a big rebuild, I'd merge it in the next rotation.