haskellPackages.warp: stop including Paths_ module by default#483172
Closed
lf- wants to merge 1 commit intoNixOS:masterfrom
Closed
haskellPackages.warp: stop including Paths_ module by default#483172lf- wants to merge 1 commit intoNixOS:masterfrom
lf- wants to merge 1 commit intoNixOS:masterfrom
Conversation
This was made possible to disable, which we should really probably just do. It might make some HTTP servers not return their version in a header, but that feels like an antipattern anyhow. See: yesodweb/wai#1044 See: https://github.com/NixOS/nixpkgs/blob/ecdb2e3a81213177cde9ce769e5f086ff24387b6/pkgs/development/haskell-modules/configuration-darwin.nix#L363-L372
Member
Author
|
dammit, wrong branch. |
Contributor
There was a problem hiding this comment.
The PR's base branch is set to master, but this PR causes 1719 rebuilds.
It is therefore considered a mass rebuild.
Please change the base branch to the right base branch for your changes (probably staging).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was made possible to disable, which we should really probably just do. It might make some HTTP servers not return their version in a header, but that feels like an antipattern anyhow.
See: yesodweb/wai#1044
See:
nixpkgs/pkgs/development/haskell-modules/configuration-darwin.nix
Lines 363 to 372 in ecdb2e3
I did try to use
nix why-dependsto verify that this is actually changing the things appearing in a.afile but didn't see anything in the diff. I am nonetheless submitting this patch because I did have this problem in practice at work; it's slightly hard to pin down the exact circumstances leading to it presenting itself.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.