haskellPackages: remove unneeded jailbreaks#482411
haskellPackages: remove unneeded jailbreaks#482411maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
|
Already merge-conflict. 😬 |
6aad3ab to
933e337
Compare
|
Rebased |
|
I haven’t yet succeeded in running nixpkgs-review on this. Building the review-shell needs 30k downloads and 12k builds. Am I holding it wrong? |
|
Do we want to run nixpkgs-review here? Removing these jailbreaks technically triggers rebuild of all packages depending on any of these, but jailbreak can only affect whether the targeted package builds or not right? |
|
Yeah, probably unnecessary. It just was a way to give this due diligence. |
|
Even to build your example nix-build command I need to compile ghc. Whatever, I trust your testing. The change looks fine and if this really breaks anything maintained we will notice. |
e604c7b
|
It would be better to merge these kinds of changes directly into staging in the future when we have a fully built haskell-updates branch already. |
New year, new automated sweep.
Tested with
9.8: Only
cabal-cargsfails to build, with a haskell source error.9.12: They all build per-se, but
patat&commonmark-wikilinare blocked on test failures for depspandoc&unicode-data.9.14: Didn't bother with it as it's very recent and lots of things don't build with it
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.