Skip to content

haskellPackages: remove unneeded jailbreaks#482411

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
alexfmpe:sweep-jailbreaks
Jan 27, 2026
Merged

haskellPackages: remove unneeded jailbreaks#482411
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
alexfmpe:sweep-jailbreaks

Conversation

@alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Jan 21, 2026

New year, new automated sweep.

Tested with

nix-build -E 'with (import ./. {}).haskell.packages.ghc910; [ arbtt arch-web cabal-cargs chimera commonmark-wikilink data-array-byte decimal-literals dual-game fused-effects granite hashable heist-extra hs-speedscope http-client-tls kind-generics-th large-generics lattices matrix-client morpheus-graphql morpheus-graphql-app morpheus-graphql-client morpheus-graphql-core morpheus-graphql-server morpheus-graphql-tests nothunks patat puresat snappy-hs tasty-checklist tasty-sugar unionmount vector wild-bind ]'

9.8: Only cabal-cargs fails to build, with a haskell source error.
9.12: They all build per-se, but patat & commonmark-wikilin are blocked on test failures for deps pandoc & unicode-data.
9.14: Didn't bother with it as it's very recent and lots of things don't build with it

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 21, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jan 21, 2026
@maralorn
Copy link
Member

Already merge-conflict. 😬

@alexfmpe
Copy link
Member Author

Rebased

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 22, 2026
@maralorn
Copy link
Member

I haven’t yet succeeded in running nixpkgs-review on this. Building the review-shell needs 30k downloads and 12k builds. Am I holding it wrong?

@alexfmpe
Copy link
Member Author

Do we want to run nixpkgs-review here? Removing these jailbreaks technically triggers rebuild of all packages depending on any of these, but jailbreak can only affect whether the targeted package builds or not right?

@maralorn
Copy link
Member

Yeah, probably unnecessary. It just was a way to give this due diligence.

@maralorn
Copy link
Member

Even to build your example nix-build command I need to compile ghc. Whatever, I trust your testing.

The change looks fine and if this really breaks anything maintained we will notice.

@maralorn maralorn added this pull request to the merge queue Jan 27, 2026
Merged via the queue into NixOS:haskell-updates with commit e604c7b Jan 27, 2026
29 of 31 checks passed
@sternenseemann
Copy link
Member

It would be better to merge these kinds of changes directly into staging in the future when we have a fully built haskell-updates branch already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants