synaptics: fix tapButtons setting

[abbradar]

This should fix an issue with tapButtons reported by @puffnfresh (sorry for the breakage!) in #4746 .

[lucabrunox]

Weird, I did an upgrade and tapping worked fine. Maybe it only affects it when disabling?
I wonder why TapButton use fingersMap, and ClickFinger use buttonsMap. That's confusing.

[abbradar]

@lethalman Precisely, it breaks only when trying to disable taps. As for fingersMap and buttonsMap -- that was my change -- I was using different maps for fingers and buttons, so splitting them was more convenient for me.

[lucabrunox]

@abbradar that's ok, but why TapButton -> fingersMap, ClickFinger -> buttonsMap? Sounds confusing to me.

[abbradar]

Now when you said it -- it really is. Maybe rename fingersMap -> tapsMap while not much people use it?

[puffnfresh]

Looks perfect. Thank you! 👍

[kirelagin]

I just wonder what is the usecase for having different maps for taps and clicks…

[kirelagin]

Hm, and BTW seems that the renaming of fingersMap to tapsMap didn’t happen. That’s unfortunate…

[abbradar]

My usecase was to disable three-buttons tap, but not click -- evolved from my habit of semi-consciously tapping on touchpad while thinking.

[kirelagin]

My usecase was to disable three-buttons tap, but not click -- evolved from my habit of semi-consciously tapping on touchpad while thinking.

Wow, that’s handy! I should probably do that as well.