buildPythonPackage: overrideStdenvCompat: show position in its warning message#481980
Open
ShamrockLee wants to merge 2 commits intoNixOS:masterfrom
Open
buildPythonPackage: overrideStdenvCompat: show position in its warning message#481980ShamrockLee wants to merge 2 commits intoNixOS:masterfrom
ShamrockLee wants to merge 2 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
ShamrockLee
force-pushed
the
build-python-stdenv-compat-message
branch
from
de6357f to
d290a12
Compare
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
Thanks for the quick follow-up!
MattSturgeon
force-pushed
the
build-python-stdenv-compat-message
branch
2 times, most recently
from
b4b2103 to
c271303
Compare
MattSturgeon
approved these changes
Jan 27, 2026
Contributor
There was a problem hiding this comment.
@ShamrockLee hope you don't mind, I pushed up some tweaks to avoid blocking this on minor stuff.
Thanks again for the follow-up! LGTM.
nixpkgs-ci
bot
added
the
12.approvals: 1
…sage Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
MattSturgeon
force-pushed
the
build-python-stdenv-compat-message
branch
from
c271303 to
773f5cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses previous PR discussions #477208 (comment) and #477208 (comment)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.