python3Packages.wrapPython: use pkgsBuildTarget.makeWrapper by default

[doronbehar]

Things done

Solve #211340 . When merged against branch master, this works for yaml-merge edited in this commit too.

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

[doronbehar]

A reproducer for the eval error:

nix build -Lf. --argstr system aarch64-darwin pkgsStatic.buildPackages.python3Packages.wrapPython --show-trace

Very peculiar why this happens only for Darwin...

[doronbehar]

A reproducer for the eval error:

nix build -Lf. --argstr system aarch64-darwin pkgsStatic.buildPackages.python3Packages.wrapPython --show-trace

Very peculiar why this happens only for Darwin...

Fixed. CC @emilazy as I see you edited the apple-sdk file and should be able to understand if I fixed it sensibly.

[emilazy]

Doesn’t look right to me, we need the non‐bootstrap SDK even for static builds. I don’t immediately follow exactly what’s pulling in extra dependencies here, but this probably needs individual packages adjusted with bootstrap logic or handling in pkgs/stdenv/darwin. cc @NixOS/darwin-core

[doronbehar]

Doesn’t look right to me, we need the non‐bootstrap SDK even for static builds. I don’t immediately follow exactly what’s pulling in extra dependencies here, but this probably needs individual packages adjusted with bootstrap logic or handling in pkgs/stdenv/darwin. cc @NixOS/darwin-core

OK I understand. It may be that the solution proposed for wrapLua here:

• luaPackages.wrapLua: Fix the wrapper on cross #481464

Can work for us too. You should know though that with this PR pkgsStatic.bash builds fine on aarch64-darwin. I didn't test it though.