buildLuarocksPackage: fix cross compilation wrapping#481511
Merged
teto merged 2 commits intoNixOS:stagingfrom Mar 12, 2026
Merged
buildLuarocksPackage: fix cross compilation wrapping#481511teto merged 2 commits intoNixOS:stagingfrom
teto merged 2 commits intoNixOS:stagingfrom
Conversation
13 tasks
doronbehar
changed the title
doronbehar
force-pushed
the
pkg/wrapLua@cross
branch
from
06f1384 to
a1ab45b
Compare
ofborg
bot
added
the
6.topic: cross-compilation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
doronbehar
commented
Jan 19, 2026
doronbehar
force-pushed
the
pkg/wrapLua@cross
branch
from
a1ab45b to
7852429
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
doronbehar
force-pushed
the
pkg/wrapLua@cross
branch
from
7852429 to
c68a1fe
Compare
github-actions
bot
dismissed
their stale review
Review dismissed automatically
Contributor
|
@teto any opinions on approach ? |
khaneliman
reviewed
Jan 30, 2026
doronbehar
force-pushed
the
pkg/wrapLua@cross
branch
from
c68a1fe to
fa6ad30
Compare
doronbehar
changed the title
doronbehar
force-pushed
the
pkg/wrapLua@cross
branch
from
fa6ad30 to
061315b
Compare
doronbehar
force-pushed
the
pkg/wrapLua@cross
branch
from
061315b to
c8ab486
Compare
Contributor
Author
|
OK so I found time to fix this properly and test it! @Artturin the changes I perform here are sort of overriding your changes here: Please if you could give your opinion on this it will be deeply appreciated 🙏. |
doronbehar
force-pushed
the
pkg/wrapLua@cross
branch
from
c8ab486 to
dae413d
Compare
Artturin
reviewed
Mar 4, 2026
Artturin
reviewed
Mar 4, 2026
patchShebangs already takes care of this automatically and does it well, before this hook runs.
- Make `lua` gain `luaOnBuildFor{Build,Host,Target}` and alike attributes.
- wrapLua: correctly substitute build & host lua & luarocks_bootstrap
- Disallow build platform references when using `buildLuarocksPackage`
in cross building.
doronbehar
force-pushed
the
pkg/wrapLua@cross
branch
from
dae413d to
7b9e4c7
Compare
Contributor
Author
|
Tested that these build properly: Let me know please if you can think of other edge cases that will challenge the changes made here. |
13 tasks
Artturin
approved these changes
Mar 11, 2026
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
Author
|
Thanks for the review and the merge!
|
vcunat
pushed a commit
that referenced
this pull request
Mar 13, 2026
(cherry picked from commit ca45c71) It looks like the rebuild costs won't be high really.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.