python3Packages.tensorflow: avoid deprecated override of pybind11

[mjoerg]

This change is necessary after #476384 to avoid the warning shown below.

$ NIXPKGS_ALLOW_BROKEN=1 nix eval --impure --experimental-features 'nix-command flakes' github:NixOS/nixpkgs/110493e24696e74e793ce4da869b44c0581197ec#libtensorflow
evaluation warning: pybind11: Passing `stdenv` directly to `buildPythonPackage` or `buildPythonApplication` is deprecated. You should use their `.override` function instead, e.g:
                      buildPythonPackage.override { stdenv = customStdenv; } { }
«derivation /nix/store/fhf64r49xvf00rx30mw3sy5jnj0fg7z9-tensorflow-2.13.0.drv»
$ NIXPKGS_ALLOW_BROKEN=1 nix eval --impure --experimental-features 'nix-command flakes' github:NixOS/nixpkgs/4d8ab9da2b93d936961827440656b384689d8d80#libtensorflow
«derivation /nix/store/fhf64r49xvf00rx30mw3sy5jnj0fg7z9-tensorflow-2.13.0.drv»

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[leona-ya]

@MattSturgeon, @ShamrockLee is this the best solution?

[MattSturgeon]

is this the best solution?

Assuming stdenv actually needs overriding, as per the existing code, then yes: this is essentially the only way to build pybind11 with a different stdenv.

Under the hood, the deprecation/compatibility layer does the same thing; overriding buildPythonPackage with the supplied stdenv:

nixpkgs/pkgs/development/interpreters/python/python-packages-base.nix

Line 62 in 63f6f2e

'' (f'.override { inherit (args) stdenv; } (removeAttrs args [ "stdenv" ]))

[MattSturgeon]

I'd typically override the previous attr, rather than supplying another one from this scope:

Suggested change

	(pybind11.override {
	buildPythonPackage = buildPythonPackage.override {
	inherit stdenv;
	};
	})
	(pybind11.override (prev: {
	buildPythonPackage = prev.buildPythonPackage.override { inherit stdenv; };
	}))

In practice, they're probably the same. But it's technically possible that someone has an overlay in which pybind11 receives a different buildPythonPackage to this package.