haskellPackages.posix-waitpid: unbreak#478857
Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom Jan 12, 2026
Merged
haskellPackages.posix-waitpid: unbreak#478857wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
danielrolls
added
the
6.topic: haskell
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nixpkgs-ci
bot
requested review from
maralorn,
sternenseemann and
wolfgangwalther
Contributor
Author
|
@wolfgangwalther, the original Hackage package has no repo and hasn't been updated since 2010. However, there's a fork at https://github.com/GaloisInc/posix-waitpid which already has this fix. We could switch to the fork if preferred. |
Contributor
|
I'd be fine with the current approach, if we were to add some of that explanation to the code comment, too. |
danielrolls
force-pushed
the
posix-waitpid-unbreak
branch
from
c9d58ac to
8fa7044
Compare
Fix CPid constructor import (needs CPid(..) for pattern matching on foreign calls) and jailbreak for version bounds. Package has been broken since GHC 7.4+ (2011) and marked broken in nixpkgs since 2016.
danielrolls
force-pushed
the
posix-waitpid-unbreak
branch
from
8fa7044 to
3d9b17a
Compare
Contributor
Author
|
@wolfgangwalther, I had a go a both. How's this? |
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
|
LGTM; I am doing a build, but this will take a while - still need to build GHC on haskell-updates right now. Will look at this tomorrow again. |
Contributor
|
Merged
via the queue into
NixOS:haskell-updates
with commit Jan 12, 2026
1b4d91b
30 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CPid constructor import (needs CPid(..) for pattern matching on foreign calls) and jailbreak for version bounds.
Package has been broken since GHC 7.4+ (2011) and marked broken in nixpkgs since 2016.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.