nzbhydra2: 8.1.2 -> 8.2.2#478821
Conversation
|
srcbot: Source verification FAILED
Step 1: Build
|
6a404f9 to
083b96e
Compare
|
@DieracDelta @matteo-pacini I've changed the Maven dependency fetcher to not use the offline mode anymore as that just caused lots of trouble and was a major hurdle towards reproducibility. Partially also because NzbHydra2 uses lots of interconnected modules in the same directory. |
|
srcbot: Source verification passed
Step 1: Build
|
DieracDelta
left a comment
There was a problem hiding this comment.
LGTM, thank you for your efforts here!!
083b96e to
c47e83f
Compare
|
Sneaky upstream published another update, so here we go again :D |
|
srcbot: Source verification passed
Step 1: Build
|
|
matteo-pacini
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
|
Hmm, I'm a little confused about the merge bot eligible label because according to my understanding this PR is not merge bot eligible. |
|
@hesiod here's the details here: https://github.com/NixOS/nixpkgs/blob/master/ci/README.md#nixpkgs-merge-bot |
srcbot: Source verification FAILED
Step 1: Build
|
|
@DieracDelta If I interpret that correctly, only the package itself is not reproducible, right? That is kind of a known issue as JARs are suboptimal in terms of reproducibility. I've tried to improve stuff in this PR (the timestamp parameter is common practice in nixpkgs), but there might still be some remaining issues. |
Yes, that's also my understanding. It's just the package itself whose output is nondeterministic. srcbot's error message is misleading -- I need to fix that! +1 diffoscope is a good idea, I'll have a look with that when some time frees up. Context: I ran srcbot again to confirm that the fetchedMavenDeps didn't return a mismatched hash. (I forgot to do |
See https://github.com/theotherp/nzbhydra2/releases/tag/v8.2.1 and previous commits.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.