llvmPackages.libllvm: disable getMacOSHostVersion on LLVM < 21#478778
Merged
vcunat merged 2 commits intoNixOS:stagingfrom Jan 11, 2026
Merged
llvmPackages.libllvm: disable getMacOSHostVersion on LLVM < 21#478778vcunat merged 2 commits intoNixOS:stagingfrom
getMacOSHostVersion on LLVM < 21#478778vcunat merged 2 commits intoNixOS:stagingfrom
Conversation
4e09056 to
5731a42
Compare
This is breaking Hydra builds. The old comment about the CoreFoundation framework is no longer relevant now that we always use the system frameworks.
5731a42 to
e44c491
Compare
Member
Author
|
I guess this can go to |
Member
Author
|
Diff of I don’t really feel like running an entire LLVM build to validate; it’s the same method we’re already using to disable the test on |
rrbutani
approved these changes
Jan 10, 2026
1 task
Contributor
alyssais
reviewed
Jan 11, 2026
| lib.versionOlder release_version "21" | ||
| || | ||
| # Rebuild avoidance; TODO: clean up on `staging`. | ||
| stdenv.hostPlatform.isx86 |
Member
There was a problem hiding this comment.
Maybe that's for easier auto-backport label?
Member
Author
There was a problem hiding this comment.
I will clean up on staging and backport to staging-25.11. This is getting backported to a release branch.
Member
|
Let's get Hydra start working (on this on 25.11). |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently untested. See commit messages.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.