libui-ng: fix tests with cmocka 2#478521
Merged
Mindavi merged 1 commit intoNixOS:masterfrom Jan 13, 2026
Merged
Conversation
Related to: NixOS#467954 Signed-off-by: Marcin Serwin <marcin@serwin.dev>
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Mindavi
reviewed
Jan 12, 2026
| ./darwin-no-universal.patch | ||
|
|
||
| # https://github.com/libui-ng/libui-ng/pull/348 | ||
| ./0001-Remove-cm_print_error-declaration.patch |
Contributor
There was a problem hiding this comment.
Using fetchpatch(2) is preferred for this, I'd say.
Member
There was a problem hiding this comment.
Actually, the patch is supposed to be vendored in this case:
When adding patches in this manner you should be reasonably sure that the used URL is stable. Patches referencing open pull requests will change when the PR is updated and code forges (such as GitHub) usually garbage collect commits that are no longer reachable due to rebases/amends.1
Footnotes
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Mindavi
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #467954
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.