Skip to content

nushellPlugins.desktop_notifications: Add Darwin platforms#478305

Open
wthueb wants to merge 1 commit intoNixOS:masterfrom
wthueb:update-nu_plugin_desktop_notifications
Open

nushellPlugins.desktop_notifications: Add Darwin platforms#478305
wthueb wants to merge 1 commit intoNixOS:masterfrom
wthueb:update-nu_plugin_desktop_notifications

Conversation

@wthueb
Copy link
Copy Markdown
Contributor

@wthueb wthueb commented Jan 9, 2026 •
edited
Loading

Adds lib.platforms.darwin to meta.platforms, as the package supports Darwin builds.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Copilot AI review requested due to automatic review settings January 9, 2026 05:54
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 9, 2026
Copilot AI reviewed Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Darwin (macOS) platform support to the nushellPlugins.desktop_notifications package by expanding the meta.platforms attribute to include both Linux and Darwin platforms.

  • Updated meta.platforms from lib.platforms.linux to lib.platforms.linux ++ lib.platforms.darwin

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wthueb
Copy link
Copy Markdown
Contributor Author

wthueb commented Jan 9, 2026

Package needs to be updated to 0.109.1 to properly be able to be used, covered via #466500

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 9, 2026
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 2, 2026
@wthueb wthueb force-pushed the update-nu_plugin_desktop_notifications branch from 6ee0a7e to 11f4e50 Compare February 3, 2026 18:04
@nixpkgs-ci nixpkgs-ci bot requested a review from timon-schelling February 3, 2026 18:10
@nixpkgs-ci nixpkgs-ci bot removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 3, 2026
@lafrenierejm
Copy link
Copy Markdown
Contributor

lafrenierejm commented Feb 8, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478305
Commit: 11f4e50e2dca0329d28441ff8a86f51fe52c1d59

aarch64-darwin

✅ 1 package built:
  • nushell-plugin-desktop_notifications (nushellPlugins.desktop_notifications)

@lafrenierejm lafrenierejm added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 8, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 9, 2026
@ilkecan

This comment was marked as outdated.

Sign in to view
ilkecan
ilkecan reviewed Feb 11, 2026
View reviewed changes
pkgs/by-name/nu/nushell-plugin-desktop_notifications/package.nix
};

cargoHash = "sha256-7ZiQr8RBQCNQK3/tLasilZcu+HWp066iDFI67L8iZMg=";

This comment was marked as outdated.

Sign in to view

pkgs/by-name/nu/nushell-plugin-desktop_notifications/package.nix
{
lib,
rustPlatform,
fetchFromGitHub,

This comment was marked as outdated.

Sign in to view

@nixpkgs-ci nixpkgs-ci bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Feb 11, 2026
@timon-schelling
Copy link
Copy Markdown
Member

timon-schelling commented Feb 11, 2026

Why did the first nixpkgs-review succeed?
Not familiar with the darwin tooling.

@wthueb
Copy link
Copy Markdown
Contributor Author

wthueb commented Feb 11, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478305
Commit: 11f4e50e2dca0329d28441ff8a86f51fe52c1d59

aarch64-darwin

✅ 1 package built:
  • nushell-plugin-desktop_notifications (nushellPlugins.desktop_notifications)

@wthueb
Copy link
Copy Markdown
Contributor Author

wthueb commented Feb 11, 2026

@timon-schelling I'm at a loss as well. My best guess is the relaxed sandbox? It was removed on Darwin here: Mic92/nixpkgs-review#161

@ilkecan
Copy link
Copy Markdown
Member

ilkecan commented Feb 12, 2026

Yes, this seems indeed caused by the sandbox; as it succeed when I triggered a build without the sandbox:

nixpkgs-review result for #478305

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 478305
Commit: 11f4e50e2dca0329d28441ff8a86f51fe52c1d59 (subsequent changes)
Merge: 8dc5b15bbb5b4fca78a5e6b652a0c6f626012463

Logs: https://github.com/ilkecan/nixpkgs-review-gha/actions/runs/21925196423

x86_64-darwin (sandbox = false)

✅ 1 package built:
  • nushell-plugin-desktop_notifications (nushellPlugins.desktop_notifications)

aarch64-darwin (sandbox = false)

✅ 1 package built:
  • nushell-plugin-desktop_notifications (nushellPlugins.desktop_notifications)

Sorry for the false positive, I will try to understand the sandbox on darwin in more detail.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Feb 12, 2026
@VuiMuich
Copy link
Copy Markdown
Contributor

VuiMuich commented Mar 4, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478305
Commit: 11f4e50e2dca0329d28441ff8a86f51fe52c1d59

VuiMuich
VuiMuich approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@VuiMuich VuiMuich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+4 more reviewers

@VuiMuich VuiMuich VuiMuich approved these changes

@lafrenierejm lafrenierejm lafrenierejm approved these changes

@timon-schelling timon-schelling timon-schelling approved these changes

@ilkecan ilkecan ilkecan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wthueb @lafrenierejm @ilkecan @timon-schelling @VuiMuich