python3Packages.sipsimple: fix build with gcc15; refactor and modernize#477157
python3Packages.sipsimple: fix build with gcc15; refactor and modernize#477157Prince213 merged 2 commits intoNixOS:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
0002e69 to
1a8c1f1
Compare
- Follow upstream and rename from `sipsimple` to `python3-sipsimple` - Use `finalAttrs` fixpoint pattern
1a8c1f1 to
1b6bf4b
Compare
|
|
Is there anything else that should be done? the fix is more important to me than the refactors, so I can split the latter into a followup if it needs more work/discussion. |
|
Successfully created backport PR for |
|
|
||
| python3-saml = callPackage ../development/python-modules/python3-saml { }; | ||
|
|
||
| python3-sipsimple = callPackage ../development/python-modules/python3-sipsimple { }; |
There was a problem hiding this comment.
I'd follow the majority on Repology and use
| python3-sipsimple = callPackage ../development/python-modules/python3-sipsimple { }; | |
| sipsimple = callPackage ../development/python-modules/sipsimple { }; |
There was a problem hiding this comment.
It is called python:sipsimple in repology, but not in the distros' repos? for example in the AUR it's python-sipsimple.
There was a problem hiding this comment.
That's Arch's standard prefix for Python packages.
There was a problem hiding this comment.
Ah, thanks for the info, that's good to know. Would you suggest renaming it again or would it be fine to keep it as python3-sipsimple since it's already like this in repology? If it's the former, perhaps we could do it for all similar packages?
There was a problem hiding this comment.
Actually, python3-sipsimple is correct in this case:
- https://github.com/AGProjects/python3-sipsimple/blob/5.3.3.2-mac/sipsimple/__info__.py#L4
- https://github.com/AGProjects/python3-sipsimple/blob/5.3.3.2-mac/setup.py#L29
It's what ends up in the METADATA file in the output.
Changes
sipsimpletopython3-sipsimplefinalAttrsfixpoint pattern (buildPython*: support fixed-point arguments #271387)Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.