Skip to content

python3Packages.sipsimple: fix build with gcc15; refactor and modernize#477157

Merged
Prince213 merged 2 commits intoNixOS:masterfrom
eljamm:fix/sipsimple-gcc15
Jan 8, 2026
Merged

python3Packages.sipsimple: fix build with gcc15; refactor and modernize#477157
Prince213 merged 2 commits intoNixOS:masterfrom
eljamm:fix/sipsimple-gcc15

Conversation

@eljamm
Copy link
Contributor

@eljamm eljamm commented Jan 5, 2026

Changes

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 5, 2026
@eljamm

This comment was marked as outdated.

@eljamm eljamm force-pushed the fix/sipsimple-gcc15 branch from 0002e69 to 1a8c1f1 Compare January 5, 2026 17:19
Copy link
Member

@Prince213 Prince213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

- Follow upstream and rename from `sipsimple` to `python3-sipsimple`
- Use `finalAttrs` fixpoint pattern
@eljamm eljamm force-pushed the fix/sipsimple-gcc15 branch from 1a8c1f1 to 1b6bf4b Compare January 5, 2026 17:38
@eljamm
Copy link
Contributor Author

eljamm commented Jan 5, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review
Commit: 1b6bf4b9aacc0bcd3f6c8d4533b28b13d7afe552


x86_64-linux

✅ 8 packages built:
  • blink-qt
  • blink-qt.dist
  • python313Packages.python3-sipsimple
  • python313Packages.python3-sipsimple.dist
  • python314Packages.python3-sipsimple
  • python314Packages.python3-sipsimple.dist
  • sylkserver
  • sylkserver.dist

@eljamm
Copy link
Contributor Author

eljamm commented Jan 8, 2026

Is there anything else that should be done? the fix is more important to me than the refactors, so I can split the latter into a followup if it needs more work/discussion.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 8, 2026
@Prince213 Prince213 added this pull request to the merge queue Jan 8, 2026
Merged via the queue into NixOS:master with commit 714a2de Jan 8, 2026
31 of 33 checks passed
@Prince213 Prince213 added the backport release-25.11 Backport PR automatically label Jan 8, 2026
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 8, 2026

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 8, 2026

python3-saml = callPackage ../development/python-modules/python3-saml { };

python3-sipsimple = callPackage ../development/python-modules/python3-sipsimple { };
Copy link
Member

@dotlambda dotlambda Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd follow the majority on Repology and use

Suggested change
python3-sipsimple = callPackage ../development/python-modules/python3-sipsimple { };
sipsimple = callPackage ../development/python-modules/sipsimple { };

Copy link
Contributor Author

@eljamm eljamm Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is called python:sipsimple in repology, but not in the distros' repos? for example in the AUR it's python-sipsimple.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's Arch's standard prefix for Python packages.

Copy link
Contributor Author

@eljamm eljamm Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for the info, that's good to know. Would you suggest renaming it again or would it be fine to keep it as python3-sipsimple since it's already like this in repology? If it's the former, perhaps we could do it for all similar packages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eljamm eljamm deleted the fix/sipsimple-gcc15 branch January 8, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants