-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
doc/python: document fixed-point arguments (#271387) #477149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doronbehar
wants to merge
4
commits into
NixOS:master
Choose a base branch
from
doronbehar:doc/buildPython@fixed-point
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5339e49
doc/python: document fixed-point arguments (#271387)
doronbehar ad54fe3
python.section.md: List finalAttrs.passthru only attributes
doronbehar daf1d46
doc/python: explain better passthru note
doronbehar 5ac2996
doc/python: simplify packageOverrides example
doronbehar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect it to inherit
pnameas well, this is one of the few times I'd think usingpnamewould be fine (as opposed to e.g:fetchFromGitHub'srepoargument).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't really. We normalize
pname(e.g. apply lowercasing), but the pypi name may not reflect that, so it is often untied.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this means while this documentation suggest untying it, tying
pnameis also accepted?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it might be stable, if the library name already is normalized, but uppercase, dashes, etc. will cause flapping every once in a while.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if you do reuse the name for
pnameandsrc.pname, it's best to use a locally defined variable rather thanfinalAttrs.pname. Values infinalAttrsrepresent the final state, including any user defined overrides.pnameis an example of something an end-user may wish to override, e.g.pname = prevAttrs.pname + "-with-my-tweaks". Such an override shouldn't propagate to thesrc's project.