Skip to content

draupnir: pin to Node.js 22#475956

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
Scrumplex:pkgs/draupnir/pin-nodejs
Jan 2, 2026
Merged

draupnir: pin to Node.js 22#475956
Aleksanaa merged 1 commit intoNixOS:masterfrom
Scrumplex:pkgs/draupnir/pin-nodejs

Conversation

@Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Jan 1, 2026

draupnir depends on better-sqlite3 ^9, which seems to not support Node.js 24.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

draupnir depends on better-splite3 ^9, which seems to not support
Node.js 24.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Jan 1, 2026
@nixpkgs-ci nixpkgs-ci bot requested a review from TheArcaneBrony January 1, 2026 17:04
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 1, 2026
@TheArcaneBrony
Copy link
Member

...huh? I've not had issues with better-sqlite3 on nodejs24...?

@TheArcaneBrony
Copy link
Member

Basic research says better-sqlite3>9 makes no sense as upstream calls for 7.x?

@Scrumplex
Copy link
Member Author

Scrumplex commented Jan 1, 2026

Basic research says better-sqlite3>9 makes no sense as upstream calls for 7.x?

See https://github.com/the-draupnir-project/Draupnir/blob/7ef871d3c70cb3b0bab88264ad15d108798e09ed/package.json#L58

I think you might have looked at @types/better-sqlite3 in the package.json file, which is indeed 7.x.x.

Either way, checking hydra logs reveals that better-sqlite3's native code is failing to build here. Note that the library in question had multiple major releases since 9.x.x, so upgrading it might be a non trivial, but still something upstream should consider.

The reason for this build failure is the recent bump from Node.js 22 to 24 for the default nodejs alias.

Copy link
Member

@TheArcaneBrony TheArcaneBrony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some chatting with the maintainer, nodejs24 indeed isn't supported yet.

This is probably fine for the time being as node22 is likely to be supported for a good bit longer.

Would like to get one or 2 more approvals to see if the sentiment is shared.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 1, 2026
@Aleksanaa Aleksanaa enabled auto-merge January 2, 2026 09:31
@Aleksanaa Aleksanaa disabled auto-merge January 2, 2026 09:31
@Aleksanaa Aleksanaa added this pull request to the merge queue Jan 2, 2026
Merged via the queue into NixOS:master with commit 7dcd75c Jan 2, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants