Skip to content

haskell.compiler: use structured attrs for hadrianFlags#475546

Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:ghc-structured-attrs
Jan 11, 2026
Merged

haskell.compiler: use structured attrs for hadrianFlags#475546
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:ghc-structured-attrs

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Dec 31, 2025

Still needs changelog entry and testing.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Dec 31, 2025
@SFrijters
Copy link
Member

Was just about to kick off a new __structuredAttrs = true; build so I'll add this into my branch for testing.

@sternenseemann
Copy link
Member Author

I was able to build haskell.packages.ghc9103 and pkgsStatic.buildPackages.haskell.compiler.ghc9122 on x86_64-linux.

Copy link
Member

@SFrijters SFrijters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this PR instead of my own hack while rebuilding my system last week and it worked for everything I was doing. I also like just having __structuredAttrs enabled here.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 7, 2026
@sternenseemann sternenseemann marked this pull request as ready for review January 8, 2026 09:10
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jan 11, 2026

Still needs changelog entry

Since I have a big rebuild lined up on haskell-updates, I will merge this now. We can add the changelog entry later.

Edit: To be clear, I'm not sure whether we need one. This doesn't change the exposed interface, so is technically not a breaking change.

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Jan 11, 2026
Merged via the queue into NixOS:haskell-updates with commit 0cc1b42 Jan 11, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants