Closed
Conversation
nixpkgs-ci
bot
added
12.first-time contribution
iamanaws
suggested changes
Dec 29, 2025
Member
There was a problem hiding this comment.
Welcome!
- Please rebase, maintainer commit should go first, then the package contribution.
- Clean/remove the third merge commit.
- Run
nix fmt
see how-to-create-pull-requests
- Create a new Git branch, ideally such that:
- The name of the branch hints at your change, e.g.
update-hello.
pkgs/by-name/xr/xray-tun/package.nix
Outdated
Member
There was a problem hiding this comment.
Suggested change
| buildGoModule (finalAttrs: { |
Member
There was a problem hiding this comment.
tag is preferred Nixpkgs Reference
Suggested change
| tag = "v${finalAttrs.version}; |
Author
There was a problem hiding this comment.
had to fix mock tests upstream first. there isn't a tag in which the fix is present
Member
There was a problem hiding this comment.
I see they just merge the fix, I think we could ask for a release upstream and wait
No rush.
Just for reference, we have unstable versioning
- version = "0.0.8";
+ version = "0.0.8-unstable-2025-12-29";
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Member
|
superseded by #475169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Init a new package, a CLI TUN client for xray VPN.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.