postgresql: use rev instead of tag

[gaelj]

Things done

As mentioned here, this code comment is misleading.

src = fetchFromGitHub {
  owner = "postgres";
  repo = "postgres";
  # rev, not tag, on purpose: allows updating when new versions
  # are "stamped" a few days before release (tag).
  inherit hash rev;
};

I suspect that the intention is to download https://github.com/postgres/postgres/archive/REL_18_1.tar.gz rather than https://github.com/postgres/postgres/archive/refs/tags/REL_18_1.tar.gz.

The updated download link works:

 wget https://github.com/postgres/postgres/archive/REL_18_1.tar.gz
--2025-12-29 15:29:54--  https://github.com/postgres/postgres/archive/REL_18_1.tar.gz
Resolving github.com (github.com)... 140.82.121.3
Connecting to github.com (github.com)|140.82.121.3|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/postgres/postgres/tar.gz/refs/tags/REL_18_1 [following]
--2025-12-29 15:29:54--  https://codeload.github.com/postgres/postgres/tar.gz/refs/tags/REL_18_1
Resolving codeload.github.com (codeload.github.com)... 140.82.121.10
Connecting to codeload.github.com (codeload.github.com)|140.82.121.10|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: ‘REL_18_1.tar.gz’

REL_18_1.tar.gz                                [                   <=>                                                                   ]  28,31M  7,28MB/s    in 3,9s    

2025-12-29 15:29:59 (7,27 MB/s) - ‘REL_18_1.tar.gz’ saved [29690303]


 ls REL_18_1.tar.gz
 REL_18_1.tar.gz

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[gaelj]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 475060
Commit: f77d4bbae8b0b53b1a9ce26ad8a29fcc8935de09

---

x86_64-linux

✅ 1 package built:

• nixpkgs-manual

[wolfgangwalther]

I suspect that the intention is to download https://github.com/postgres/postgres/archive/REL_18_1.tar.gz rather than https://github.com/postgres/postgres/archive/refs/tags/REL_18_1.tar.gz.

Nope, that's not the intention. The code is exactly as intended.

We want to use the tag - but for a few days before each new release, we pin a specific commit instead of the tag.

[Ma27]

(see for instance 07885bc)

[gaelj]

Oh right, I see ! Sorry for the noise then.