haskellPackages.MIP: fix broken, disable tests#474911
haskellPackages.MIP: fix broken, disable tests#474911wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
|
I know Am I supposed to add it to
|
|
It's fine to add it manually with a brief note what's wrong. |
8faf298 to
829f2c0
Compare
|
@sternenseemann thank you! Done. I have done the move of MIP-glpk to broken in a separate commit; let me me know if you want them squashed. |
wolfgangwalther
left a comment
There was a problem hiding this comment.
I have done the move of MIP-glpk to broken in a separate commit; let me me know if you want them squashed.
Yes, they should be squashed into one commit, since they form one logical unit.
The hackage zip is missing some of the test data, thus the tests fail. This was raised in msakai/haskell-MIP#87 Until this is fixed upstream, we disable the tests. With the fix of MIP, MIP-glpk is now broken not because of MIP failing but because of a problem with the module itself. The module doesn't build because of an incomatibility with extended-reals >=0.2.7.0. This has been addressed upstream msakai/haskell-MIP@60a5ee2 but has not been released, yet.
829f2c0 to
18701ff
Compare
Done; thank you! |
|
|
The darwin failures are about some dependencies (bytestring-encoding), so not a problem of this PR. |
The hackage zip is missing some of the test data,
thus the tests fail.
This was raised in msakai/haskell-MIP#87 Until this is fixed upstream, we disable the tests.
The package MIP-glpk was transitively failing on MIP, but is now failing on its own right; so this commit does not fix that.
Things done
MIPfrom broken.yamlMIPin configuration-common.nix./maintainers/scripts/haskell/regenerate-hackage-packages.sh -fTested:
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.