Skip to content

haskellPackages.MIP: fix broken, disable tests#474911

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
wchresta:mip-fix-disable-tests
Jan 10, 2026
Merged

haskellPackages.MIP: fix broken, disable tests#474911
wolfgangwalther merged 1 commit intoNixOS:masterfrom
wchresta:mip-fix-disable-tests

Conversation

@wchresta
Copy link
Member

The hackage zip is missing some of the test data,
thus the tests fail.
This was raised in msakai/haskell-MIP#87 Until this is fixed upstream, we disable the tests.

The package MIP-glpk was transitively failing on MIP, but is now failing on its own right; so this commit does not fix that.

Things done

Tested:

$ nix-shell -K -I nixpkgs=. -p 'haskellPackages.ghcWithPackages (p: [p.MIP])'
[..]
$ ghci
GHCi, version 9.10.3: https://www.haskell.org/ghc/  :? for help
ghci> import qualified Numeric.Optimization.MIP as MIP
ghci> :t MIP.readFile
MIP.readFile
  :: MIP.FileOptions
     -> FilePath -> IO (MIP.Problem Data.Scientific.Scientific)
  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Dec 28, 2025
@wchresta
Copy link
Member Author

wchresta commented Dec 29, 2025

I know MIP-glpk will be newly broken instead of transitively broken; but I don't have a hydra build to link to.

Am I supposed to add it to broken.yaml myself or let the build system do it's thing?

--------- Report for 'x86_64-linux' ---------
8 packages marked as broken and skipped:
haskellPackages.ersatz-toysat haskellPackages.ersatz-toysat.doc haskellPackages.qhull haskellPackages.qhull.doc haskellPackages.satchmo-toysat haskellPackages.satchmo-toysat.doc haskellPackages.toysolver haskellPackages.toysolver.doc

2 packages failed to build:
haskellPackages.MIP-glpk haskellPackages.MIP-glpk.doc

4 packages built:
haskell.package-list haskellPackages.MIP haskellPackages.MIP.doc nixpkgs-manual

@sternenseemann
Copy link
Member

It's fine to add it manually with a brief note what's wrong.

@wchresta wchresta force-pushed the mip-fix-disable-tests branch 2 times, most recently from 8faf298 to 829f2c0 Compare January 6, 2026 08:13
@wchresta
Copy link
Member Author

wchresta commented Jan 6, 2026

@sternenseemann thank you! Done. I have done the move of MIP-glpk to broken in a separate commit; let me me know if you want them squashed.

Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done the move of MIP-glpk to broken in a separate commit; let me me know if you want them squashed.

Yes, they should be squashed into one commit, since they form one logical unit.

The hackage zip is missing some of the test data,
thus the tests fail.
This was raised in msakai/haskell-MIP#87
Until this is fixed upstream, we disable the tests.

With the fix of MIP, MIP-glpk is now broken not because of
MIP failing but because of a problem with the module itself.

The module doesn't build because of an incomatibility with
extended-reals >=0.2.7.0. This has been addressed upstream
msakai/haskell-MIP@60a5ee2
but has not been released, yet.
@wchresta wchresta force-pushed the mip-fix-disable-tests branch from 829f2c0 to 18701ff Compare January 6, 2026 15:57
@wchresta
Copy link
Member Author

wchresta commented Jan 6, 2026

I have done the move of MIP-glpk to broken in a separate commit; let me me know if you want them squashed.

Yes, they should be squashed into one commit, since they form one logical unit.

Done; thank you!

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 474911
Commit: 18701fff4051d73e3cf3b4d7581ec428cb0ab0aa


x86_64-linux

✅ 3 packages built:
  • haskell.package-list
  • haskellPackages.MIP
  • haskellPackages.MIP.doc

aarch64-linux

✅ 3 packages built:
  • haskell.package-list
  • haskellPackages.MIP
  • haskellPackages.MIP.doc

x86_64-darwin

❌ 2 packages failed to build:
  • haskellPackages.MIP
  • haskellPackages.MIP.doc
✅ 1 package built:
  • haskell.package-list

aarch64-darwin

❌ 2 packages failed to build:
  • haskellPackages.MIP
  • haskellPackages.MIP.doc
✅ 1 package built:
  • haskell.package-list

@wolfgangwalther
Copy link
Contributor

The darwin failures are about some dependencies (bytestring-encoding), so not a problem of this PR.

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Jan 10, 2026
Merged via the queue into NixOS:master with commit 5ec7af3 Jan 10, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants