haskellPackages.inspection-testing: mark broken in pkgsStatic

[sternenseemann]

We can build it, but it's useless as compiler plugins are incompatible with -fexternal-interpreter

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[sternenseemann]

@ofborg build pkgsStatic.haskellPackages.vector

[wolfgangwalther]

Since we have enableExternalInterpreter for the generic builder we could use this in an override where we disable that, right?

I think a better change would be to doCheck = !self.inspection-testing.meta.broken && !old.enableExternalInterpreter for vector?

[sternenseemann]

Since we have enableExternalInterpreter for the generic builder we could use this in an override where we disable that, right?

No, it is only possible to inspect arguments insofar they have been given explicitly via the overriding interface. It is a shortcoming of haskellPackages.mkDerivation that the effective arguments aren't properly inspectable.

In any case what I wanted to avoid for now was another mechanism for disabling inspection-testing given we already have one, but I agree that this could probably be refactored to be cleaner.

[sternenseemann]

However we do it, disabling the test suite of vector is currently enough to get postgrest to build again in pkgsStatic.

[wolfgangwalther]

The alternative is to just force disable enableExternalInterpreter for vector, because it's not needed anyway.

Edit: I wonder whether we could generally only enable the external interpreter when the package depends on template-haskell?

[sternenseemann]

Loading the plugin requires the same sort of loading which we can’t do for >= 9.6 without external interpreter, so it’s a catch 22.

[alexfmpe]

Edit: I wonder whether we could generally only enable the external interpreter when the package depends on template-haskell?

I don't think you need the template-haskell package dependency to use the TemplateHaskell extension.