Skip to content

imagemagick: fix cross compile#474586

Merged
dotlambda merged 3 commits intoNixOS:stagingfrom
onny:php-imagick-update
Jan 31, 2026
Merged

imagemagick: fix cross compile#474586
dotlambda merged 3 commits intoNixOS:stagingfrom
onny:php-imagick-update

Conversation

@onny
Copy link
Contributor

@onny onny commented Dec 27, 2025 •
edited
Loading

Fix RiscV cross-compilation in imagick and imagemagick

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: php PHP is a general-purpose scripting language geared towards web development. labels Dec 27, 2025
@onny onny added the 6.topic: riscv64 RISC-V is an open standard instruction set architecture label Dec 27, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 27, 2025
@onny onny force-pushed the php-imagick-update branch from 2f7be19 to 713b832 Compare December 27, 2025 19:25
@onny onny marked this pull request as ready for review December 27, 2025 19:25
@onny onny added the backport release-25.11 Backport PR automatically label Dec 27, 2025
@onny onny force-pushed the php-imagick-update branch from 713b832 to 5057276 Compare December 27, 2025 19:36
@onny onny changed the base branch from master to staging December 27, 2025 19:36
@nixpkgs-ci nixpkgs-ci bot closed this Dec 27, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 27, 2025
dotlambda
dotlambda reviewed Dec 29, 2025
View reviewed changes
@onny onny changed the title phpPackages.imagick: 3.8.0 -> 3.8.1 phpExtensions.imagick: 3.8.0 -> 3.8.1 Dec 29, 2025
@piotrkwiecinski
Copy link
Contributor

piotrkwiecinski commented Jan 17, 2026 •
edited
Loading

This also fixes compatibility for php 8.5 #481104

@piotrkwiecinski piotrkwiecinski mentioned this pull request Jan 18, 2026
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 8.has: package (update) This PR updates a package to a newer version label Jan 27, 2026
@onny
Copy link
Contributor Author

onny commented Jan 28, 2026

thanks for the reminder, this week i will still be busy but continue to work on this on sunday. otherwise feel free to take over

@piotrkwiecinski piotrkwiecinski mentioned this pull request Jan 28, 2026
Merged
4 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 29, 2026
@onny onny force-pushed the php-imagick-update branch from 5057276 to db523d4 Compare January 29, 2026 11:56
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 29, 2026
@onny onny force-pushed the php-imagick-update branch from db523d4 to c04e1db Compare January 29, 2026 12:00
@onny onny marked this pull request as draft January 29, 2026 12:00
@onny onny force-pushed the php-imagick-update branch from c04e1db to 7b6acd4 Compare January 29, 2026 12:01
@github-actions github-actions bot dismissed their stale review January 29, 2026 12:02

Review dismissed automatically

@onny onny force-pushed the php-imagick-update branch from 7b6acd4 to 8e7640e Compare January 29, 2026 12:04
@onny onny requested a review from drupol January 29, 2026 12:05
@onny onny marked this pull request as ready for review January 29, 2026 12:05
@onny
Copy link
Contributor Author

onny commented Jan 29, 2026

Updated commits, ready for review now :)

@nixpkgs-ci nixpkgs-ci bot removed 8.has: package (update) This PR updates a package to a newer version 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 29, 2026
faukah
faukah reviewed Jan 29, 2026
View reviewed changes
@onny onny force-pushed the php-imagick-update branch from 8e7640e to 1b70645 Compare January 29, 2026 18:30
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 29, 2026
@onny onny force-pushed the php-imagick-update branch from 1b70645 to 624d040 Compare January 31, 2026 06:50
@dotlambda dotlambda added this pull request to the merge queue Jan 31, 2026
Merged via the queue into NixOS:staging with commit 458c2f1 Jan 31, 2026
28 of 31 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 31, 2026

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-474586-to-release-25.11 origin/release-25.11
cd .worktree/backport-474586-to-release-25.11
git switch --create backport-474586-to-release-25.11
git cherry-pick -x 7a2727154913a70f3c7102e608a608a3e7c70672 e7a4c6ced979298c8c97d84a8596736e5e9752a3 624d04074e6ebcfa7889c33b1552a7f8d20ead7f

@aszenz aszenz mentioned this pull request Feb 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@drupol drupol drupol approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@aanderse aanderse Awaiting requested review from aanderse

@Ma27 Ma27 Awaiting requested review from Ma27

@piotrkwiecinski piotrkwiecinski Awaiting requested review from piotrkwiecinski

@rhendric rhendric Awaiting requested review from rhendric

@talyz talyz Awaiting requested review from talyz

+1 more reviewer

@faukah faukah faukah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: php PHP is a general-purpose scripting language geared towards web development. 6.topic: riscv64 RISC-V is an open standard instruction set architecture 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@onny @piotrkwiecinski @drupol @dotlambda @faukah