-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel-watcher: init at 0.5.0 #47448
bazel-watcher: init at 0.5.0 #47448
Conversation
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
rm -rf $bazelOut/external/{local_*,\@local_*} | ||
''; | ||
|
||
sha256 = "0m7sjlbhg3p3l3mhs5smd28mj3zyzf6jrk3dgg0mjfb3zwfnfz32"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're sure this hash was correct at the time, this derivation is not stable. I immediately got a hash mismatch here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, thx for checking @srhb, probably something else needs to be removed before computing the hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srhb can you try to build it and upload the $out
for the /nix/store/...-bazel-watcher-2018-09-09-deps
? Thank you!
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
5ccf839
to
27f0714
Compare
Success on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good and builds locally for me. :) A couple of things:
If this is not a released version, it should be named "bazel-watcher-unstable-2018-09-09". Is there any reason to not use a released version?
I believe the convention for the commit message is to also use the "version" as above, eg "init at 2018-09-09"
Bazel computes the default value of output_user_root before parsing the flag[0]. The computation of the default value involves getting the $USER from the environment. I don't have that variable when building with sandbox enabled. [0]: https://github.com/bazelbuild/bazel/blob/9323c57607d37f9c949b60e293b573584906da46/src/main/cpp/startup_options.cc#L123-L124
27f0714
to
86a5535
Compare
@srhb I was pointing to a specific revision because of my patch upstream bazelbuild/bazel-watcher@4d5928e that's needed for a successful packaging. But since my commit is just one after the released version v0.5.0, I have updated the PR to use the release and just import the patch. PTAL. |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I'd like to understand why it fails to build on ofborg. Are there any other assumptions about the -dep bit that break CI somehow?
@srhb sorry I gave you the wrong PR, I meant this #46509 (comment) |
@GrahamcOfBorg build bazel-watcher |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
@GrahamcOfBorg build bazel-watcher |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
@grahamc Do you know what this error is about? It appears to work just fine locally, sandboxed and all. https://logs.nix.ci/?key=nixos/nixpkgs.47448&attempt_id=4a8c1c59-ccb8-424a-b8ed-ce5d6c8fe945 |
@grahamc also I tried restarting the build a few times in #46509, and it did end up succeeding a few time. I'll give it another try. @GrahamcOfBorg build bazel-watcher |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: bazel-watcher Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: bazel-watcher Partial log (click to expand)
|
The error was traced to a bug specific to nix 2.0.1. 2.0.2 or later are fine. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)/cc @mboes @Profpatsch @xeji