Skip to content

buildVscode: init#474458

Merged
mdaniels5757 merged 3 commits intoNixOS:masterfrom
qweered:build-vscode
Jan 25, 2026
Merged

buildVscode: init#474458
mdaniels5757 merged 3 commits intoNixOS:masterfrom
qweered:build-vscode

Conversation

@qweered
Copy link
Contributor

@qweered qweered commented Dec 26, 2025 •
edited
Loading

Split from #453948
kiro-code on mac was broken previously and i don't know how to fix it

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@qweered qweered marked this pull request as draft December 27, 2025 00:06
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 29, 2025
@qweered qweered force-pushed the build-vscode branch 2 times, most recently from 7023313 to 8058be7 Compare January 11, 2026 15:53
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 11, 2026
@qweered qweered force-pushed the build-vscode branch 3 times, most recently from 45b5ce0 to 736f425 Compare January 11, 2026 16:08
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Jan 11, 2026
@qweered qweered marked this pull request as ready for review January 11, 2026 16:15
@qweered
Copy link
Contributor Author

qweered commented Jan 11, 2026 •
edited
Loading

yeah kiro-code on mac broke previously and i don't know how to fix it

@qweered

This comment was marked as outdated.

Sign in to view
Zaczero
Zaczero approved these changes Jan 12, 2026
View reviewed changes
Copy link
Member

@Zaczero Zaczero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

antigravity works

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 12, 2026
sarahec
sarahec approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@sarahec sarahec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for Windsurf

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 12, 2026
@Vuks69
Copy link
Contributor

Vuks69 commented Jan 12, 2026

I'm unable to debug kiro here, as I do not own a Mac and I seem unable to build the darwin package from an x86_64-linux system.

$ NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix-build -A pkgsCross.x86_64-darwin.kiro
... some traces ...
error: infinite recursion encountered

@qweered
Copy link
Contributor Author

qweered commented Jan 22, 2026

I seem unable to build the darwin package from an x86_64-linux system.

as you can see it works in nixpkgs-github-action and locally for me

@qweered
Copy link
Contributor Author

qweered commented Jan 22, 2026

cc @wolfgangwalther and @emilazy as original authors

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jan 22, 2026

I specifically said I'm not pursuing this myself anymore in #453948 (comment), so I won't review it either ;)

@qweered
Copy link
Contributor Author

qweered commented Jan 23, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 474458
Commit: e157104d21f0818309cd789057768b8d104ae9e3 (subsequent changes)
Merge: f57dd2cdac75199e38957eaac1f6d7428c21f112

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/21291659800

x86_64-linux

✅ 12 packages built:
  • antigravity
  • antigravity-fhs
  • code-cursor
  • code-cursor-fhs
  • kiro
  • kiro-fhs
  • vscode
  • vscode-fhs
  • vscode-with-extensions
  • vscodium
  • vscodium-fhs
  • windsurf

aarch64-linux

✅ 9 packages built:
  • antigravity
  • antigravity-fhs
  • code-cursor
  • code-cursor-fhs
  • vscode
  • vscode-fhs
  • vscode-with-extensions
  • vscodium
  • vscodium-fhs

x86_64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • kiro
✅ 6 packages built:
  • antigravity
  • code-cursor
  • vscode
  • vscode-with-extensions
  • vscodium
  • windsurf
Error logs: `x86_64-darwin`
kiro 
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/a696k0w6z0icddp39clm2vsnz2b90lkq-kiro-ide-0.8.140-stable-darwin-x64.dmg
do not know how to unpack source archive /nix/store/a696k0w6z0icddp39clm2vsnz2b90lkq-kiro-ide-0.8.140-stable-darwin-x64.dmg

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • kiro
✅ 6 packages built:
  • antigravity
  • code-cursor
  • vscode
  • vscode-with-extensions
  • vscodium
  • windsurf
Error logs: `aarch64-darwin`
kiro 
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/24gdc1xzfsianw5nbcv92nsx625yqawn-kiro-ide-0.8.140-stable-darwin-arm64.dmg
do not know how to unpack source archive /nix/store/24gdc1xzfsianw5nbcv92nsx625yqawn-kiro-ide-0.8.140-stable-darwin-arm64.dmg

@qweered
Copy link
Contributor Author

qweered commented Jan 23, 2026

I am daily driving this for two weeks with antigravity and cursor and have no issues

@qweered qweered mentioned this pull request Jan 25, 2026
Closed
13 tasks
@qweered qweered requested a review from mdaniels5757 January 25, 2026 18:58
mdaniels5757
mdaniels5757 approved these changes Jan 25, 2026
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, kiro failure on Darwin is pre-existing.

@mdaniels5757 mdaniels5757 added this pull request to the merge queue Jan 25, 2026
Merged via the queue into NixOS:master with commit c0fbc2c Jan 25, 2026
30 of 32 checks passed
@qweered qweered deleted the build-vscode branch January 26, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@aspauldingcode aspauldingcode Awaiting requested review from aspauldingcode

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@eadwu eadwu Awaiting requested review from eadwu

@jamesward jamesward Awaiting requested review from jamesward

@JeffLabonte JeffLabonte Awaiting requested review from JeffLabonte

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

@Prince213 Prince213 Awaiting requested review from Prince213

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@Vuks69 Vuks69 Awaiting requested review from Vuks69

@xiaoxiangmoe xiaoxiangmoe Awaiting requested review from xiaoxiangmoe

+2 more reviewers

@Zaczero Zaczero Zaczero approved these changes

@sarahec sarahec sarahec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@qweered @Vuks69 @wolfgangwalther @mdaniels5757 @Zaczero @sarahec