Skip to content

Fix OCaml cross-compilation issue for dune and opaline#473890

Merged
vbgl merged 1 commit intoNixOS:masterfrom
ecofighter:fix-opaline-crosscompile
Dec 26, 2025
Merged

Fix OCaml cross-compilation issue for dune and opaline#473890
vbgl merged 1 commit intoNixOS:masterfrom
ecofighter:fix-opaline-crosscompile

Conversation

@ecofighter
Copy link
Copy Markdown
Contributor

@ecofighter ecofighter commented Dec 24, 2025 •
edited
Loading

  • Inherit ocamlPackages in dune package definition
  • Add opaline package with proper ocamlPackages inheritance

This will fix the cross-compilation issue (#473684).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ecofighter
fix: resolve cross-compilation issue for dune and opaline
d5e1eee 
- Inherit ocamlPackages in dune package definition
- Add opaline package with proper ocamlPackages inheritance
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Dec 24, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Dec 24, 2025
@vbgl vbgl added this pull request to the merge queue Dec 26, 2025
@vbgl vbgl added the backport release-25.11 Backport PR automatically label Dec 26, 2025
Merged via the queue into NixOS:master with commit 66579df Dec 26, 2025
32 of 34 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Dec 26, 2025

Successfully created backport PR for release-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 26, 2025
Merged
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 26, 2025
kfiz pushed a commit to kfiz/nixpkgs that referenced this pull request Dec 26, 2025
@vbgl @kfiz
Fix OCaml cross-compilation issue for dune and opaline (NixOS#473890)
c5782e8
kfiz pushed a commit to kfiz/nixpkgs that referenced this pull request Dec 26, 2025
@vbgl @kfiz
Fix OCaml cross-compilation issue for dune and opaline (NixOS#473890)
2fdd6e2
@vbgl vbgl mentioned this pull request Feb 2, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 8.has: port to stable This PR already has a backport to the stable release. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ecofighter @vbgl