Skip to content

various: move toPythonApplications from by-name to avoid override weirdness#473624

Draft
qweered wants to merge 6 commits intoNixOS:masterfrom
qweered:python-consolidate-top-lovel
Draft

various: move toPythonApplications from by-name to avoid override weirdness#473624
qweered wants to merge 6 commits intoNixOS:masterfrom
qweered:python-consolidate-top-lovel

Conversation

@qweered
Copy link
Contributor

@qweered qweered commented Dec 23, 2025

Following discussion in #454559 i think this is an immidiate improvement to restore override interface

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@qweered qweered marked this pull request as draft December 23, 2025 17:23
@qweered qweered force-pushed the python-consolidate-top-lovel branch 5 times, most recently from 0601a39 to 3f2ec5a Compare December 24, 2025 14:46
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Dec 24, 2025
@qweered qweered force-pushed the python-consolidate-top-lovel branch 2 times, most recently from 7a6e0b5 to 1187cc1 Compare December 24, 2025 15:34
@nixpkgs-ci nixpkgs-ci bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 24, 2025
@qweered qweered force-pushed the python-consolidate-top-lovel branch from 1187cc1 to da832f4 Compare December 24, 2025 15:44
@qweered qweered marked this pull request as ready for review December 24, 2025 15:44
@qweered qweered changed the title various: move from by-name to avoid override weirdness various: move toPythonApplications from by-name to avoid override weirdness Dec 24, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 24, 2025
@qweered
Copy link
Contributor Author

qweered commented Dec 24, 2025

cc @NixOS/nixpkgs-core

@qweered
Copy link
Contributor Author

qweered commented Dec 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 473624
Commit: da832f4d819b95b58912ad5d95312b2d3e24d1c2


x86_64-linux

✅ 4 packages built:
  • reno
  • reno.dist
  • sbom4python
  • sbom4python.dist

@qweered qweered force-pushed the python-consolidate-top-lovel branch 5 times, most recently from 592cfdb to c58a88c Compare December 24, 2025 16:20
@alyssais
Copy link
Member

Seems more like something for the Python package set maintainers than the core team…

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 26, 2025
@qweered qweered requested a review from mweinelt December 28, 2025 22:42
@qweered qweered requested a review from natsukium December 28, 2025 22:42
@qweered
Copy link
Contributor Author

qweered commented Dec 28, 2025

cc @mweinelt @natsukium as python team members for review

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 28, 2025
@qweered qweered force-pushed the python-consolidate-top-lovel branch from c58a88c to e74bcd1 Compare December 28, 2025 22:47
@mweinelt
Copy link
Member

mweinelt commented Dec 28, 2025

  • TBD: e74bcd1 all-packages: move toPythonApplication packages closer to each other
  • NACK: 8019b2d treewide: move almost all toPythonApplication from by-name to top-level overlay to fix override interface
    • No reason given and I don't understand what this changes
  • OK: 7db157f sbom4files: add mainProgram
  • OK: 226f6fd circus, reno: use python3Packages
  • TODO: 5e8ee08 python3Packages.kubernetes-validate: move expression to appropriate place
    • commit message should specify the reason
  • OK: 4e62e3d gfal2-util: remove unneeded overlay

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 28, 2025
@qweered
Copy link
Contributor Author

qweered commented Dec 28, 2025

See reason for 8019b2d in #454559 discussion and specifically #454559 (comment). This commit allows all arguments to be overriden again

@qweered qweered force-pushed the python-consolidate-top-lovel branch from e74bcd1 to cbac7c7 Compare December 28, 2025 23:17
@qweered qweered force-pushed the python-consolidate-top-lovel branch from cbac7c7 to 487a8d6 Compare December 28, 2025 23:26
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 29, 2025
@wolfgangwalther
Copy link
Contributor

See reason for 8019b2d in #454559 discussion and specifically #454559 (comment). This commit allows all arguments to be overriden again

Just because a migration in one direction breaks the override interface we don't need to immediately migrate everything in the other direction. Since that override interface was not there to begin with, nobody is relying on it right now. Or in other words: The comment you referenced pointed out two problems: The removal of the existing override interface without replacement - and the fact that after the migration, there is no proper override interface for these packages. Both are problems, but only the latter is the case here, and I don't think it warrants this kind of migration right now.

@qweered
Copy link
Contributor Author

qweered commented Feb 10, 2026

Converting to draft until we aggree on proper solution

@qweered qweered marked this pull request as draft February 10, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants