various: move toPythonApplications from by-name to avoid override weirdness#473624
various: move toPythonApplications from by-name to avoid override weirdness#473624qweered wants to merge 6 commits intoNixOS:masterfrom
Conversation
0601a39 to
3f2ec5a
Compare
7a6e0b5 to
1187cc1
Compare
1187cc1 to
da832f4
Compare
|
cc @NixOS/nixpkgs-core |
|
592cfdb to
c58a88c
Compare
|
Seems more like something for the Python package set maintainers than the core team… |
|
cc @mweinelt @natsukium as python team members for review |
c58a88c to
e74bcd1
Compare
|
|
See reason for 8019b2d in #454559 discussion and specifically #454559 (comment). This commit allows all arguments to be overriden again |
it was fixed in NixOS@f05a131
e74bcd1 to
cbac7c7
Compare
This is a preparation for moving kubernetes-validate from by-name to top-level
…el overlay to fix override interface
cbac7c7 to
487a8d6
Compare
Just because a migration in one direction breaks the override interface we don't need to immediately migrate everything in the other direction. Since that override interface was not there to begin with, nobody is relying on it right now. Or in other words: The comment you referenced pointed out two problems: The removal of the existing override interface without replacement - and the fact that after the migration, there is no proper override interface for these packages. Both are problems, but only the latter is the case here, and I don't think it warrants this kind of migration right now. |
|
Converting to draft until we aggree on proper solution |
Following discussion in #454559 i think this is an immidiate improvement to restore override interface
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.