[TEST] jetbrains: idea-oss, pycharm-oss: 2025.1.1.1 -> 2025.3 + fetchurl: builder.sh: handle urls as a Bash array#472992
Closed
theCapypara wants to merge 18 commits intoNixOS:masterfrom
Closed
Conversation
Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
Clean up leftover for commit cd13136 ("fetchurl: use __structuredAttrs = true and pass curlOptsList directly") Continue the work of commit 23236b3 ("fetchurl: fix handling of fallback URLs"), addressing a Bash array re-assignment quirk: when assigning a Bash array variable as if it were a plain variable, the value goes to the first element, and the rest of the array stays the same. ```console $ foo=(a b) $ declare -p foo declare -a foo=([0]="a" [1]="b") $ foo="c d" $ declare -p foo declare -a foo=([0]="c d" [1]="b") ``` Don't rewrite the `${urls[@]}` with resolved URLs, but hold them with `${resolvedUrls[@]}` instead. Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk> Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
…re name arguments
…ls-fix' into jetbrains/update-src-2025.3-try-with-471851
Member
Author
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines #471851 and #470774 for the sole reason to test if the combination of these PRs builds with
nixpkgs-review-gha.